interpet and expose Secure Notes

detunized · Oct 26, 2020 · 4313409 · 4313409
1 parent 4d9241a
commit 4313409
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 7 deletions.
diff --git a/lib/lastpass.rb b/lib/lastpass.rb
@@ -12,6 +12,7 @@
 require "lastpass/exceptions"
 require "lastpass/http"
 require "lastpass/fetcher"
+require "lastpass/note"
 require "lastpass/parser"
 require "lastpass/session"
 require "lastpass/vault"

diff --git a/lib/lastpass/note.rb b/lib/lastpass/note.rb
@@ -0,0 +1,15 @@
+module LastPass
+    class Note
+        attr_reader :id,
+                    :name,
+                    :notes,
+                    :group
+
+        def initialize id, name, notes, group
+            @id = id
+            @name = name
+            @notes = notes
+            @group = group
+        end
+    end
+end
diff --git a/lib/lastpass/parser.rb b/lib/lastpass/parser.rb
@@ -7,7 +7,7 @@ class Parser
         RSA_PKCS1_OAEP_PADDING = 4
 
         # Secure note types that contain account-like information
-        ALLOWED_SECURE_NOTE_TYPES = {
+        ACCOUNT_LIKE_SECURE_NOTE_TYPES = {
             "Server" => true,
             "Email Account" => true,
             "Database" => true,
@@ -49,8 +49,8 @@ def self.parse_ACCT chunk, encryption_key
                 # Parse secure note
                 if secure_note == "1"
                     parsed = parse_secure_note_server notes
-                    if !ALLOWED_SECURE_NOTE_TYPES.key? parsed[:type]
-                        return nil
+                    if !ACCOUNT_LIKE_SECURE_NOTE_TYPES.key? parsed[:type]
+                      return Note.new id, name, notes, group
                     end
 
                     url = parsed[:url] if parsed.key? :url

diff --git a/lib/lastpass/vault.rb b/lib/lastpass/vault.rb
@@ -3,7 +3,7 @@
 
 module LastPass
     class Vault
-        attr_reader :accounts
+        attr_reader :accounts, :notes
 
         # Fetches a blob from the server and creates a vault
         def self.open_remote username, password, multifactor_password = nil, client_id = nil
@@ -37,7 +37,11 @@ def initialize blob, encryption_key
                 private_key = Parser.parse_private_key blob.encrypted_private_key, encryption_key
             end
 
-            @accounts = parse_accounts chunks, encryption_key, private_key
+            @accounts, @notes = parse_accounts chunks, encryption_key, private_key
+        end
+
+        def accounts_and_notes
+          @accounts_and_notes ||= @accounts + @notes
         end
 
         def complete? chunks
@@ -46,15 +50,19 @@ def complete? chunks
 
         def parse_accounts chunks, encryption_key, private_key
             accounts = []
+            notes = []
             key = encryption_key
 
             chunks.each do |i|
                 case i.id
                 when "ACCT"
                     # TODO: Put shared folder name as group in the account
                     account = Parser.parse_ACCT i, key
-                    if account
+                    case account
+                    when Account
                         accounts << account
+                    when Note
+                        notes << account
                     end
                 when "SHAR"
                     raise "private_key must be provided" if !private_key
@@ -64,7 +72,7 @@ def parse_accounts chunks, encryption_key, private_key
                 end
             end
 
-            accounts
+            [ accounts, notes ]
         end
     end
 end