parse updates to lastpass

[kspearrin]

Hey, thanks for this library. We are trying to use it to build some migration tools from other password managers into Bitwarden.

I am working with LastPass for now and noticed two issues:

1. Favorites and notes was missing from the Account object. I added those in. I also added an Shared boolean property that tells us in the LastPass account came from a shared folder or not.

2. UPDATE: I added a configuration option for this with a new static ParserOptions class.

   Here you are trying to parse Accounts that are marked as a secure note back to an Account structure. And if it cannot be parsed that way (for example, a credit card of address), they are skipped. We need these to still be included for our importer. In my PR here, I just skip this logic by adding false to the condition, but obviously this is not ideal. Do you suggest any other way to handle this or turn this functionality off? Perhaps with some sort of static settings assignment, ParseNotesToAccount = false or someting?

3. Your LastPass example console app was not referencing the correct config.yaml property for client-id

[detunized]

Thank you for contributing. I'm currently traveling without access to a computer. I'll review and merge if it's ok right after I'm back at the end of the week.

…

On Tue, Feb 14, 2023, 22:57 Kyle Spearrin ***@***.***> wrote: Hey, thanks for this library. We are trying to use it to build some migration tools from other password managers into Bitwarden. I am working with LastPass for now and noticed two issues: 1. Favorites and notes was missing from the Account object. I added those in. 2. Here <https://github.com/detunized/password-manager-access/blob/master/src/LastPass/Parser.cs#L57-L65> you are trying to parse Accounts that are marked as a secure note back to an Account structure. And if it cannot be parsed that way (for example, a credit card of address), they are skipped. We need these to still be included for our importer. In my PR here, I just skip this logic by adding false to the condition, but obviously this is not ideal. Do you suggest any other way to handle this or turn this functionality off? Perhaps with some sort of static settings assignment, ParseNotesToAccount = false or someting? ------------------------------ You can view, comment on, or merge this pull request online at: #86 Commit Summary - 4cca993 <4cca993> parse updates to lastpass File Changes (2 files <https://github.com/detunized/password-manager-access/pull/86/files>) - *M* src/LastPass/Account.cs <https://github.com/detunized/password-manager-access/pull/86/files#diff-5672bfb2aee0366800c4763fb165cbb340406fadea8a829467ac543bd0af98ad> (6) - *M* src/LastPass/Parser.cs <https://github.com/detunized/password-manager-access/pull/86/files#diff-bef5fc4c400af83e7b83a90460331c45ad3be3db95756ac60597f4ba430a909f> (6) Patch Links: - https://github.com/detunized/password-manager-access/pull/86.patch - https://github.com/detunized/password-manager-access/pull/86.diff — Reply to this email directly, view it on GitHub <#86>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB35EOACPJ6XJ2YOVPKCYDWXP5TJANCNFSM6AAAAAAU4C7F74> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[detunized]

I'm back and will check all this, test with real data, possibly rework a bit and merge. Thanks for the PR.

[kspearrin]

I'm back and will check all this, test with real data, possibly rework a bit and merge. Thanks for the PR.

Great. We just published a tool that is powered by this library. See https://github.com/bitwarden/importer

Please let me know when these updates are available and I can close out the referenced issues.

[detunized]

@kspearrin, I released v10.3.0 on NuGet. It contains the changes you've added. I made some changes though.

1. Renamed Favorite and Shared to IsFavorite and IsShared.
2. Changed the type of IsFavorite from string to bool. This makes more sense.
3. An instance of ParserOptions is passed to Vault.Open. I removed the static class to avoid having global state.

Would that be possible for you to add a link to this project in the readme of bitwarden/importer?

[kspearrin]

@detunized Thanks. Updated the project here: bitwarden/importer@bc5b795

Special thank you added to the readme here: bitwarden/importer@b3804be

[detunized]

Thank you!