Replace strcpy() for overlapping string operation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meag
referenced
this pull request
in akat1/mvdsv
Sep 23, 2015
Including unused functions, strlcpy(3) misuse etc.
meag
changed the title
strcpy() not safe for overlapping strings, causes corruption in stored userinfo strings.
meag
added a commit
that referenced
this pull request
Jan 12, 2016
Replace strcpy() for overlapping string operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[First commit replaced with Q_strcpy() from ezquake, @fzwoch pointed out memmove() was cleaner].
Userinfo strings were becoming corrupted when removing a key from the string, causing players to disappear from qtv, spectators appearing as players, and/or players appearing but having default/blank names & colours.
Bug must depend on strcpy implementation - couldn't replicate in Windows.
In Linux: