name-service: Migrate to cosmwasm v0.11.0 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
reviewed
Oct 5, 2020
orkunkl
changed the title
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
orkunkl
force-pushed
the
cw-0.11.0-name-service
branch
from
73675e2
to
868afda
Compare
…-examples into cw-0.11.0-name-service
orkunkl
changed the title
maurolacy
approved these changes
Oct 14, 2020
| } | ||
|
|
||
| const coralnetOptions: Options = { | ||
| httpUrl: 'https://lcd.coralnet.cosmwasm.com', |
There was a problem hiding this comment.
Suggested change
| httpUrl: 'https://lcd.coralnet.cosmwasm.com', | |
| httpUrl: 'https://rest.cosmwasm.hub.hackatom.dev', |
|
|
||
| const coralnetOptions: Options = { | ||
| httpUrl: 'https://lcd.coralnet.cosmwasm.com', | ||
| networkId: 'cosmwasm-coral', |
There was a problem hiding this comment.
Suggested change
| networkId: 'cosmwasm-coral', | |
| networkId: 'hackatom-wasm', |
| source: "https://github.com/CosmWasm/cosmwasm-examples/tree/nameservice-0.7.0/nameservice", | ||
| builder: "cosmwasm/rust-optimizer:0.10.4" | ||
| }; | ||
| const sourceUrl = "https://github.com/CosmWasm/cosmwasm-examples/releases/download/nameservice-0.7.0/contract.wasm"; |
There was a problem hiding this comment.
Suggested change
| const sourceUrl = "https://github.com/CosmWasm/cosmwasm-examples/releases/download/nameservice-0.7.0/contract.wasm"; | |
| const sourceUrl = "https://raw.githubusercontent.com/CosmWasm/cosmwasm-examples/master/mask/artifacts/cw_nameservice.wasm"; |
| * Usage: npx @cosmjs/cli --init https://raw.githubusercontent.com/CosmWasm/cosmwasm-examples/master/nameservice/helpers.ts | ||
| * | ||
| * Create a client: | ||
| * const client = await useOptions(coralnetOptions).setup(password); |
There was a problem hiding this comment.
Suggested change
| * const client = await useOptions(coralnetOptions).setup(password); | |
| * const client = await useOptions(heldernetOptions).setup(password); |
| * await client.getAccount() | ||
| * | ||
| * Get the mnemonic: | ||
| * await useOptions(coralnetOptions).recoverMnemonic(password) |
There was a problem hiding this comment.
Suggested change
| * await useOptions(coralnetOptions).recoverMnemonic(password) | |
| * await useOptions(heldernetOptions).recoverMnemonic(password) |
| readonly gasLimits: Partial<GasLimits<CosmWasmFeeTable>> // only set the ones you want to override | ||
| } | ||
|
|
||
| const coralnetOptions: Options = { |
There was a problem hiding this comment.
Suggested change
| const coralnetOptions: Options = { | |
| const heldernetOptions: Options = { |
Comment on lines
+83
to
+84
| coralnetOptions.gasPrice, | ||
| coralnetOptions.gasLimits, |
There was a problem hiding this comment.
Suggested change
| coralnetOptions.gasPrice, | |
| coralnetOptions.gasLimits, | |
| heldernetOptions.gasPrice, | |
| heldernetOptions.gasLimits, |
Comment on lines
+99
to
+100
| const wallet = await loadOrCreateWallet(coralnetOptions, keyfile, password); | ||
| const client = await connect(wallet, coralnetOptions); |
There was a problem hiding this comment.
Suggested change
| const wallet = await loadOrCreateWallet(coralnetOptions, keyfile, password); | |
| const client = await connect(wallet, coralnetOptions); | |
| const wallet = await loadOrCreateWallet(heldernetOptions, keyfile, password); | |
| const client = await connect(wallet, heldernetOptions); |
|
|
||
| const recoverMnemonic = async (password: string, filename?: string): Promise<string> => { | ||
| const keyfile = filename || options.defaultKeyFile; | ||
| const wallet = await loadOrCreateWallet(coralnetOptions, keyfile, password); |
There was a problem hiding this comment.
Suggested change
| const wallet = await loadOrCreateWallet(coralnetOptions, keyfile, password); | |
| const wallet = await loadOrCreateWallet(heldernetOptions, keyfile, password); |
Merged
|
Should I go ahead and apply the remaining changes, so we can merge this? As a way to validate it, it could be a good opportunity for me to learn how to deploy it to testnet, and verify it's working. |
|
@maurolacy please take over this. Orkun is on vacation next week. Can you verifiy the JS scripts work? Here are all the network info for Heldernet: https://gist.github.com/webmaster128/6385a7e1885211d9937ada2688ce34c3 |
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Cw 0.12.0 name service
|
This includes the upgrade 0.10 -> 0.11 -> 0.12 now in one PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #94
Don't merge until cosmwasm/v0.11.0 is released