New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move `contextive.path` default to `Contextive.LanguageServer` for vscode extension #51

Closed

chrissimon-au opened this issue Oct 10, 2023 · 7 comments

Labels

Contributor

chrissimon-au commented Oct 10, 2023

This is started on #49 but the vscode extension still defines the default in the extension package.json.

This issue is to remove it from there and ensure that the new default defined in the server is used.

chrissimon-au changed the title ~~Move contextive.path default to Contextive.LanguageServer~~ Move contextive.path default to Contextive.LanguageServer for vscode extension

chrissimon-au mentioned this issue

Try to get contextive definitions if not defined in the config #49

Merged

Contributor Author

chrissimon-au commented Oct 15, 2023

Noting that the config value defined in the vscode extension is currently used by the initialise command to know where to deposit the default file. Suggest using this as an opportunity to move the initialize handling to a custom lsp command handled in the language server, so it can be leveraged by other implementations as well.

chrissimon-au added a commit that referenced this issue


          test(vscode): refactor vscode tests in preparation for #51

cd26edd

chrissimon-au closed this as completed in

050e7ee

Contributor Author

chrissimon-au commented Nov 21, 2023

We have switched to using the language server custom contextive/initialize command now, but kept the default value in the contextive vscode extension package.json for two reasons:

keeping the default value allows vscode to show the default value in the settings editor, which is clearer UX
when the default value is null, the omnisharp library fails to retrieve the settings

Since we now have the default contextive.path value defined in two places (vscode extension and language server), the e2e test of the vscode extension acts as a guard against the default value changing, and the error message marks that it should match the default defined in the server.

chrissimon-au added a commit that referenced this issue


          refactor(vscode): use language-server custom command to initialize de…

2dc3895

…finitions file (fixes #51)

chrissimon-au added a commit that referenced this issue


          refactor(vscode): use language-server custom command to initialize de…

c77a1cc

…finitions file (fixes #51)

chrissimon-au added a commit that referenced this issue


          refactor(vscode): use language-server custom command to initialize de…

0ca1111

…finitions file (fixes #51)

chrissimon-au added released and removed released labels

chrissimon-au added a commit that referenced this issue


          refactor(vscode): use language-server custom command to initialize de…

922e659

…finitions file (fixes #51)

Contributor Author

chrissimon-au commented Mar 11, 2024

🎉 This issue has been resolved in version 1.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

chrissimon-au added the released label

Contributor Author

chrissimon-au commented Mar 11, 2024

🎉 This issue has been resolved in version 1.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

3 similar comments

Contributor Author

chrissimon-au commented Mar 11, 2024

🎉 This issue has been resolved in version 1.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Contributor Author

chrissimon-au commented Mar 11, 2024

🎉 This issue has been resolved in version 1.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Contributor Author

chrissimon-au commented Mar 11, 2024

🎉 This issue has been resolved in version 1.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment