-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
978, Part 1, Creating onboarding modal component #1003
978, Part 1, Creating onboarding modal component #1003
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test comment for tutorial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code looks good, Jude. From what I see, it all equates greatly.
@@ -11,8 +11,8 @@ Modal.setAppElement("#__next"); | |||
* @description This is custom modal for the user onboarding. | |||
*/ | |||
export default function UserOnboardingModal({isOpen}) { | |||
const [modalIsOpen, setModalIsOpen] = useState(isOpen); | |||
|
|||
const [modalIsOpen, setModalIsOpen] = useState(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Jude!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, everything looks like it is working
This is part 1 of my PR. These changes will allow other team members to start working on their stories, as they were dependent on mine.
Changes:
I will later create another PR for part 2 of this story.