Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

978, Part 1, Creating onboarding modal component #1003

Merged

Conversation

judeamos
Copy link
Contributor

@judeamos judeamos commented Apr 7, 2023

This is part 1 of my PR. These changes will allow other team members to start working on their stories, as they were dependent on mine.

Changes:

  1. I've created a folder called UserOnboardingModal and corresponding files, that will house all onboarding processes/pages situated in the modal.
  2. I've modified me.js where the UserProfilePage component renders the UserProfile component, to show the modal when the username of the user is empty. (This will be refined in later PRs).
  3. I have created the basic styling of the UserOnboardingModal in the StyledUserOnboardingModal.js file.

I will later create another PR for part 2 of this story.

@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2023

⚠️ No Changeset found

Latest commit: 11fc0ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

@judeamos judeamos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test comment for tutorial

Copy link
Contributor

@erinsgithubpage erinsgithubpage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code looks good, Jude. From what I see, it all equates greatly.

@@ -11,8 +11,8 @@ Modal.setAppElement("#__next");
* @description This is custom modal for the user onboarding.
*/
export default function UserOnboardingModal({isOpen}) {
const [modalIsOpen, setModalIsOpen] = useState(isOpen);

const [modalIsOpen, setModalIsOpen] = useState(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Jude!

@judeamos judeamos merged commit 14e8c2b into development/user-profile Apr 7, 2023
Copy link
Contributor

@HavreLoic HavreLoic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, everything looks like it is working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants