Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR9: fix(alicefate): return error page when Url wrong #1062

Merged
merged 2 commits into from
May 11, 2023
Merged

PR9: fix(alicefate): return error page when Url wrong #1062

merged 2 commits into from
May 11, 2023

Conversation

alicefate
Copy link
Contributor

No description provided.

@alicefate alicefate requested a review from dbradham April 23, 2023 21:29
@alicefate alicefate requested a review from a team as a code owner April 23, 2023 21:29
@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: e9b1687

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dbradham
dbradham approved these changes Apr 30, 2023
View reviewed changes
Copy link
Collaborator

@dbradham dbradham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alicefate alicefate merged commit a2a7850 into development/ideaspace May 11, 2023
1 of 3 checks passed
@dev-launchers-flux
Copy link
Collaborator

🎉 This PR is included in version 2.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@alicefate alicefate deleted the alicefate/pr9 branch July 7, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbradham dbradham dbradham approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alicefate @dev-launchers-flux @dbradham