Yacine/fixing nav lists warning and adding other search keys to projects page #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacineKahlerras
commented
Jun 22, 2023
yacineKahlerras
commented
- fixed "key prop" warning in navigation
- added more keys to the fuse search in the projects page
|
yacineKahlerras
changed the title
yacineKahlerras
changed the title
Enjoy2Live
reviewed
Jul 1, 2023
| @@ -46,12 +46,12 @@ const NavDropdown = ({ title, isOpen = false, links }: NavDropdownProps) => { | |||
| <Options> | |||
| {links.map(({ text, href }, i) => { | |||
| return ( | |||
| <> | |||
| <div key={i}> | |||
There was a problem hiding this comment.
please don't add a new div, this might change the behavior of the component, do this instead to add key prop:
<React.Fragment key={i}>
....
</React.Fragment>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.