Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): remove old color tokens #1791

Merged
merged 8 commits into from
Jun 15, 2024

Conversation

Nouri-Anouar
Copy link
Contributor

Removed outdated colors to prevent duplication and minimize confusion.
We've removed the following colors from our palette, providing updated equivalents for each:

  • Light Blue -> Uranus.
  • Blue -> Neptune.
  • Yellow -> Saturn.
  • Orange -> Jupiter.

@Nouri-Anouar Nouri-Anouar requested a review from a team as a code owner May 11, 2024 13:15
Copy link

changeset-bot bot commented May 11, 2024

⚠️ No Changeset found

Latest commit: 93a4318

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Enjoy2Live Enjoy2Live changed the base branch from master to development/design-team May 14, 2024 03:56
@Enjoy2Live Enjoy2Live requested review from Enjoy2Live, pyxld-kris and a team as code owners May 14, 2024 03:56
@Enjoy2Live Enjoy2Live changed the base branch from development/design-team to development/components May 14, 2024 03:57
@Enjoy2Live Enjoy2Live changed the base branch from development/components to development/design-team May 14, 2024 04:01
Copy link
Member

@Enjoy2Live Enjoy2Live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, next time make sure your PR destination is development/design-team or directly push to development/design-team. so that the github action that transform tokens from the json file to tailwind classes runs.

thanks for the PR Anwar 🚀

@Nouri-Anouar
Copy link
Contributor Author

@Enjoy2Live I removed more deprecated colors:

  • Notifications
  • Success
  • Error
  • Grayscale

Please review and let me know if this is breaking anything.

@Enjoy2Live
Copy link
Member

@Nouri-Anouar
I still can see Yellow and Blue and Orange in this PR but you mentioned your goal was to remove them?

Also you removed things [GreyScale-charcoal=#474747 and GreyScale-grey = #7f7e7f] that were used in switch and pagination, how should we replace them now?

./packages/UI/src/components/Switch/Switch.tsx
  57:29  error    Classname 'data-disabled:!bg-GreyScale-charcoal' is not a Tailwind CSS class!  tailwindcss/no-custom-classname

./packages/UI/src/components/Pagination/Pagination.tsx
  48:30  error    Classname 'text-GreyScale-grey' is not a Tailwind CSS class!  tailwindcss/no-custom-classn

@Nouri-Anouar
Copy link
Contributor Author

@Enjoy2Live those Yellow, Blue, and Orange colors are those we default TailwindCSS ones. Should we keep them?

As for GreyScale-charcoal and GreyScale-grey, can we replace both with grayscale-500?

@Enjoy2Live
Copy link
Member

Enjoy2Live commented Jun 7, 2024

@Enjoy2Live those Yellow, Blue, and Orange colors are those we default TailwindCSS ones. Should we keep them?

it's up to you whether we should keep them or not, you said you wanted to remove them and I found them so I was just making sure that you didn't overlook it.

As for GreyScale-charcoal and GreyScale-grey, can we replace both with grayscale-500?

why not!

@Enjoy2Live Enjoy2Live merged commit d118db7 into development/design-team Jun 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants