Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1703 Side nav bar design #1806

Closed
wants to merge 3 commits into from
Closed

Conversation

tiwarineelu59
Copy link
Contributor

No description provided.

@tiwarineelu59 tiwarineelu59 requested review from a team as code owners May 29, 2024 22:38
Copy link

changeset-bot bot commented May 29, 2024

⚠️ No Changeset found

Latest commit: b6ca222

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tiwarineelu59 tiwarineelu59 changed the base branch from master to development/user-profile May 29, 2024 22:39
Comment on lines 27 to 30
extend: {
colors: {
'sky-blue': '#7dd3fc',
}},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiwarineelu59 why are you adding this new color? this needs to be approved by design team.

@Nouri-Anouar please check if this should be added or not

Copy link
Contributor Author

@tiwarineelu59 tiwarineelu59 May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Enjoy2Live This color was used in the user profile design layout for one of the texts but was not able to apply so I had to add this in tailwind.config.js let me know if I have to do things differently

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tiwarineelu59
Could you please provide me the Figma link where this color is being used?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiwarineelu59 just making sure you are receiving these notifications, if you do sorry for the additional ping!

Copy link
Contributor Author

@tiwarineelu59 tiwarineelu59 Jun 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nouri-Anouar It's only used in a small section, such as for the name in the right corner beside the profile picture. https://www.figma.com/design/D31z19f4we75VkmEGzdyUn/User-Profile-%2F-Onboarding-Main-File-(Copy)?node-id=2239-18693&m=deva
User Profile

@tiwarineelu59 tiwarineelu59 requested a review from a team as a code owner June 30, 2024 23:57
Copy link
Collaborator

@dbradham dbradham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in IdeaSpace are all related to cleaning code & refactoring. Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants