Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jeyanthi sm/years experience1758 #1835

Merged
merged 12 commits into from
Jul 1, 2024

Conversation

ajaywayase
Copy link
Contributor

No description provided.

@ajaywayase ajaywayase requested review from a team as code owners June 25, 2024 06:35
Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: 8a8859d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -11,12 +11,12 @@ export interface NewApplicant {
commitment: number;
extraInfo?: string;
portfolioLink?: string;
yearsExperience?: number;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field is nowhere to be found in the api response.

@becevka do we plan to add this to applicants collection?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Strapiv4 repository has a pull request waiting for review -
dev-launchers/strapiv4#193

experience: string;
reason: string;
accepted: boolean;
zip: number;
role: string;
//id?: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id is part of the response, why did you comment it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to insert the applicant details when Id was present . I get this error -

[2024-06-27 07:54:27.942] error: insert into applicants (accepted, age, commitment, created_at, email, experience, id, level, name,
published_at, reason, role, updated_at, years_experience, zip) values (false, 0, 21, '2024-06-27 07:54:27.940', 'June27@gmail.com', 'sss', '1', 'intermediate', 'June27', '2024-06-27 07:54:27.917', 'sss', 'Front-end Developer', '2024-06-27 07:54:27.940', 43, '0') returning id - UNIQUE constraint failed: applicants.id
SqliteError: insert into applicants (accepted, age, commitment, created_at, email, experience, id, level, name, published_at, reason, role, updated_at, years_experience, zip) values (false, 0, 21, '2024-06-27 07:54:27.940', 'June27@gmail.com', 'sss', '1', 'intermediate',
'June27', '2024-06-27 07:54:27.917', 'sss', 'Front-end Developer', '2024-06-27 07:54:27.940', 43, '0') returning id - UNIQUE constraint failed: applicants.id
at Client_BetterSQLite3._query (C:\Users\meenu\devlaunchers\strapiv4\node_modules\knex\lib\dialects\better-sqlite3\index.js:39:40)
at executeQuery (C:\Users\meenu\devlaunchers\strapiv4\node_modules\knex\lib\execution\internal\query-executioner.js:37:17)
at Client_BetterSQLite3.query (C:\Users\meenu\devlaunchers\strapiv4\node_modules\knex\lib\client.js:154:12)
at Runner.query (C:\Users\meenu\devlaunchers\strapiv4\node_modules\knex\lib\execution\runner.js:141:36)
at ensureConnectionCallback (C:\Users\meenu\devlaunchers\strapiv4\node_modules\knex\lib\execution\internal\ensure-connection-callback.js:13:17)
at Runner.ensureConnection (C:\Users\meenu\devlaunchers\strapiv4\node_modules\knex\lib\execution\runner.js:318:20)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Runner.run (C:\Users\meenu\devlaunchers\strapiv4\node_modules\knex\lib\execution\runner.js:30:19)
at async Object.execute (C:\Users\meenu\devlaunchers\strapiv4\node_modules@strapi\database\dist\index.js:4248:22)
at async Object.create (C:\Users\meenu\devlaunchers\strapiv4\node_modules@strapi\database\dist\index.js:5022:19)

After commenting out this line, the record got inserted in the applicant content type.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I pass an empty string or a space to the field id, I get this error -

[2024-06-27 11:14:01.469] error: insert into applicants (accepted, age, commitment, created_at, email, experience, id, level, name,
published_at, reason, role, updated_at, years_experience, zip) values (false, 0, 17, '2024-06-27 11:14:01.468', 'rt@gmail.com', 'ssss', '',
'intermediate', 'rtrtrt', '2024-06-27 11:14:01.450', 'sss', 'Front-end Developer', '2024-06-27 11:14:01.468', 55, '0') returning id - datatype mismatch
SqliteError: insert into applicants (accepted, age, commitment, created_at, email, experience, id, level, name, published_at, reason, role, updated_at, years_experience, zip) values (false, 0, 17, '2024-06-27 11:14:01.468', 'rt@gmail.com', 'ssss', '', 'intermediate', 'rtrtrt', '2024-06-27 11:14:01.450', 'sss', 'Front-end Developer', '2024-06-27 11:14:01.468', 55, '0') returning id - datatype mismatch
at Client_BetterSQLite3._query (C:\Users\meenu\devlaunchers\strapiv4\node_modules\knex\lib\dialects\better-sqlite3\index.js:39:40)
at executeQuery (C:\Users\meenu\devlaunchers\strapiv4\node_modules\knex\lib\execution\internal\query-executioner.js:37:17)
at Client_BetterSQLite3.query (C:\Users\meenu\devlaunchers\strapiv4\node_modules\knex\lib\client.js:154:12)
at Runner.query (C:\Users\meenu\devlaunchers\strapiv4\node_modules\knex\lib\execution\runner.js:141:36)
at ensureConnectionCallback (C:\Users\meenu\devlaunchers\strapiv4\node_modules\knex\lib\execution\internal\ensure-connection-callback.js:13:17)
at Runner.ensureConnection (C:\Users\meenu\devlaunchers\strapiv4\node_modules\knex\lib\execution\runner.js:318:20)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Runner.run (C:\Users\meenu\devlaunchers\strapiv4\node_modules\knex\lib\execution\runner.js:30:19)
at async Object.execute (C:\Users\meenu\devlaunchers\strapiv4\node_modules@strapi\database\dist\index.js:4248:22)
at async Object.create (C:\Users\meenu\devlaunchers\strapiv4\node_modules@strapi\database\dist\index.js:5022:19)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the line that was removed (commented).

Copy link
Member

@Enjoy2Live Enjoy2Live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please go over the requested changes and let me know if you have questions or any feedback

Copy link
Member

@Enjoy2Live Enjoy2Live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@jeyanthi-sm jeyanthi-sm merged commit 8a8859d into development/recruitment Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants