Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move UserOnboarding component in to a new component that will contain… #974

Merged
merged 4 commits into from
Apr 2, 2023
Merged

Move UserOnboarding component in to a new component that will contain… #974

merged 4 commits into from
Apr 2, 2023

Conversation

HavreLoic
Copy link
Contributor

… first time user data collection through the onboarding process

@HavreLoic
Move UserOnboarding component in to a new component that will contain…
7617e4f 
… first time user data collection through the onboarding process
@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4cefb8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@HavreLoic HavreLoic requested review from pyxld-kris and judeamos and removed request for pyxld-kris and judeamos March 30, 2023 08:58
judeamos
judeamos reviewed Apr 1, 2023
View reviewed changes
apps/website/src/components/modules/UserOnboardingProcess/UserOnboarding/UserOnboarding.js Outdated
import { Checkbox } from '@devlaunchers/components/components/atoms'
import { Link } from '@devlaunchers/components/components/atoms'
import OnboardingForm from './OnboardingForm'
import Button from '../../../../../../packages/UI/src/components/atoms/Button'
import Button from '../../../../../../../packages/UI/src/components/atoms/Button'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use @develaunchers/components/components/atoms/Buttonpath instead of '../../../../'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting this error
2023-04-02
This is when I am using @develaunchers/components/components/atoms/Button

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have try with @develaunchers/components/components/atoms/Button and @develaunchers/components/atoms/Button

judeamos
judeamos reviewed Apr 1, 2023
View reviewed changes
apps/website/src/components/modules/UserOnboardingProcess/UserOnboarding/UserOnboarding.js Outdated
import FormField from '../../../../../../packages/UI/src/components/organisms/FormField'
import OpenResponse from '../../../../../../packages/UI/src/components/organisms/OpenResponse'
import FormField from '../../../../../../../packages/UI/src/components/organisms/FormField'
import OpenResponse from '../../../../../../../packages/UI/src/components/organisms/OpenResponse'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use @develaunchers/components/components/organisms/OpenResponse

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting this error
2023-04-02 (1)
This is when I am using @develaunchers/components/components/organisms/OpenResponse

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have try with @develaunchers/components/components/organisms/OpenResponse and @develaunchers/components/organisms/OpenResponse

apps/website/src/components/modules/UserOnboardingProcess/UserOnboarding/UserOnboarding.js Show resolved Hide resolved
@judeamos judeamos merged commit 5afed32 into development/user-profile Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@judeamos judeamos judeamos left review comments

@pyxld-kris pyxld-kris Awaiting requested review from pyxld-kris pyxld-kris is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HavreLoic @judeamos