Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Havre loic/first time user interests next page 965 #991

Conversation

HavreLoic
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2023

⚠️ No Changeset found

Latest commit: 948d25d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -13,6 +13,7 @@ import { ThemeProvider } from 'styled-components';
import theme from '../styles/theme';
import Script from 'next/script';
import iubendaScript from '../scripts/iubendaScript';
import { OnboardingProvider } from '../../website/src/context/OnboardingContext'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will double-check to see if this is the right _app.js file to import context api

@judeamos judeamos merged commit 940f527 into development/user-profile Apr 5, 2023
@judeamos
Copy link
Contributor

judeamos commented Apr 5, 2023

I've had a look at the code, and the code looks fine. I will merge changes and test it out locally as well. There may be two changes I may need to make after merging:

  1. Modifying folder structure so that <UserOnboarding /> is utilised in the onboarding.js file instead of <BasicInformation />.

    • <UserOnboarding /> is a better description of what the page does vs <BasicInformation />
  2. I will double-check to see if the context API is being used in the correct _app.js file.

    • the current change is done in the _app.js located in apps/app path, but what's actually imported and used to construct the pages is the _app.js located in the apps/website path.

I will create a new branch and create a new PR for upcoming changes.
@HavreLoic Just updating you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants