This repository has been archived by the owner on Dec 26, 2020. It is now read-only.
Use ansible version compare module #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BentoumiTech
force-pushed
the
fixes/use-ansible-version-compare
branch
3 times, most recently
from
0ed9951
to
813fe1c
Compare
BentoumiTech
force-pushed
the
fixes/use-ansible-version-compare
branch
3 times, most recently
from
0f258b2
to
2946170
Compare
|
Hey @Neophy7e, thanks for opening this. I could not reproduce your issue with the comparisions though. For me its working as intended. One more thing though: can you please change the minimum ansible version to 2.5 in the meta/main.yml and in the readme? The version-filter was renamed in 2.5. Thanks! |
Signed-off-by: neophy7e <kbentoumi@gmail.com>
Signed-off-by: neophy7e <kbentoumi@gmail.com> Signed-off-by: neophy7e <> Signed-off-by: neophy7e <kbentoumi@gmail.com>
Signed-off-by: neophy7e <kbentoumi@gmail.com>
Signed-off-by: neophy7e <kbentoumi@gmail.com>
BentoumiTech
force-pushed
the
fixes/use-ansible-version-compare
branch
from
0158553
to
e0e2ea5
Compare
|
Hey @rndmh3ro just pushed both change ! |
|
Thank You! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did multiple test and none of the current comparaisons made in jinja template works. Ansible provides some helper test and one of them is to help with version comparing.
This PR fixes #184