This repository has been archived by the owner on Dec 26, 2020. It is now read-only.
Renaming Ansible variables discovered from systems #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 24, 2020 16:54
…d in new namespace ansible_facts.* Signed-off-by: Povilas <pga@tiatechnology.com>
…d in new namespace ansible_facts.* Signed-off-by: Povilas <pga@tiatechnology.com>
|
Thanks for this @PovilasGT! If you feel like it, we have some more ansible-roles that'd need this: https://github.com/dev-sec?q=ansible-&type=&language= If not, totally fine too. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming ansible variables discovered from
systems: Factsto be placed in new namespace ansible_facts.*According to Ansible documentation system discovered variables have now their own namespace -
ansible_facts.*This was introduced in Ansible version 2.5. Variables that are being gathered as facts and written to old main namespace will be deprecated in future releases.https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_2.5.html#ansible-fact-namespacing
Since the requirements say that we should use Ansible > 2.5, variables should be changed.