Oracle support

[rndmh3ro]

• Add check for Oracle operating systems
• Add minus sign to remove whitespace

[chris-rock]

Great work. I try to get it running on Oracle Linux, but ansible installations fails as you mentioned yesterday. How do you test this?

[chris-rock]

@rndmh3ro Should add support CentOS as well?

[rndmh3ro]

CentOS is already supported, because it is in the "Redhat"-os-family. Oracle Linux, while a clone of Redhat, decided to be in a separate os-family:

-----> Execute command on default-ubuntu-1204.ago",                                                                   o" 
        "ansible_os_family": "Debian", 
-----> Execute command on default-ubuntu-1404.
        "ansible_os_family": "Debian", 
-----> Execute command on default-centos-64.
        "ansible_os_family": "RedHat", 
-----> Execute command on default-centos-65.
        "ansible_os_family": "RedHat", 
-----> Execute command on default-oracle-64.
        "ansible_os_family": "Oracle Linux", 
-----> Execute command on default-oracle-65.
        "ansible_os_family": "Oracle Linux", 

Now we can check the OS with one OR and one AND:

{% elif (ansible_os_family == 'RedHat' or ansible_os_family == 'Oracle Linux') and ansible_distribution_major_version <= '6' -%}

Or I could change it to make it clearer, what operating-systems are used, but then I have to use 2 ORs and one AND:

{% elif (ansible_distribution == 'RedHat' or ansible_distribution == 'Oracle Linux' or ansible_distribution == 'CentOS') and ansible_distribution_major_version <= '6' -%}

What do you prefer?

[chris-rock]

I think the first one fits well. Thanks for the clarification.

[rndmh3ro]

I found an inconsistency with the version-checking of the OS. I'm going to create a new PR.

[chris-rock]

+1

[rndmh3ro]

Great work. I try to get it running on Oracle Linux, but ansible installations fails as you mentioned yesterday. How do you test this?

Right now I don't know how to test Oracle fully automatically.
The problem is that Ansible requires PyYAML. This package is in one of the oracle-repositories that is disabled by default. That's why the installation fails.
To work-around this, I have to run bundle exec create oracle to create the machines, then execute the following command to install PyYAML:
bundle exec kitchen exec default-oracle-65 -c "sudo sed -i 's/enabled=0/enabled=1/g' /etc/yum.repos.d/public-yum-ol6.repo && sudo yum install -y PyYAML"
Then the machine can be converged.

[chris-rock]

Thanks for pointing this out!