New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RH family: adapt some settings, as RH has better defaults #177

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
3 participants
@artem-sidorenko
Member

artem-sidorenko commented Oct 31, 2017

dev-sec/linux-baseline#82

Its WIP as the linux-baseline PR is not merged yet

RH family: adapt some settings, as RH has better defaults
dev-sec/linux-baseline#82

Signed-off-by: Artem Sidorenko <artem@posteo.de>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 31, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 944a1a2 on redhat into ab5a27d on master.

coveralls commented Oct 31, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 944a1a2 on redhat into ab5a27d on master.

@shoekstra

This comment has been minimized.

Show comment
Hide comment
@shoekstra

shoekstra Nov 9, 2017

Contributor

Hi @artem-sidorenko,

Is this ready to merge? the linux-baseline PR has been merged and the puppet and ansible one are done, would be good to get these fixes into the Supermarket.

Cheers,

Contributor

shoekstra commented Nov 9, 2017

Hi @artem-sidorenko,

Is this ready to merge? the linux-baseline PR has been merged and the puppet and ansible one are done, would be good to get these fixes into the Supermarket.

Cheers,

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Nov 9, 2017

Member

@shoekstra I want to add the fix with log permissions (see CI details) here in order to get the CI tests green. I'll do that as soon as I have time, hopefully this week.

Member

artem-sidorenko commented Nov 9, 2017

@shoekstra I want to add the fix with log permissions (see CI details) here in order to get the CI tests green. I'll do that as soon as I have time, hopefully this week.

@shoekstra

This comment has been minimized.

Show comment
Hide comment
@shoekstra

shoekstra Nov 9, 2017

Contributor

Hi @artem-sidorenko, as this PR only addresses rhel related updates in dev-sec/linux-baseline#82 I would be in favour of merging this as is because the related tests are passing and then fixing the non-rhel failed tests in a separate PR, something I'm happy to help with if you like? Alternatively I could create a separate PR for the non-rhel tests so long and then merge them all when ready?

Thoughts?

Contributor

shoekstra commented Nov 9, 2017

Hi @artem-sidorenko, as this PR only addresses rhel related updates in dev-sec/linux-baseline#82 I would be in favour of merging this as is because the related tests are passing and then fixing the non-rhel failed tests in a separate PR, something I'm happy to help with if you like? Alternatively I could create a separate PR for the non-rhel tests so long and then merge them all when ready?

Thoughts?

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Nov 9, 2017

Member

@shoekstra fair enough. Would you provide another PR, which fixes the failing log-related things? If yes, I would merge this PR

Member

artem-sidorenko commented Nov 9, 2017

@shoekstra fair enough. Would you provide another PR, which fixes the failing log-related things? If yes, I would merge this PR

@shoekstra

This comment has been minimized.

Show comment
Hide comment
@shoekstra
Contributor

shoekstra commented Nov 9, 2017

@artem-sidorenko artem-sidorenko changed the title from WIP: RH family: adapt some settings, as RH has better defaults to RH family: adapt some settings, as RH has better defaults Nov 9, 2017

@artem-sidorenko artem-sidorenko merged commit 0476764 into master Nov 9, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@artem-sidorenko artem-sidorenko deleted the redhat branch Nov 9, 2017

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Nov 9, 2017

Member

@shoekstra here you are:-)

Member

artem-sidorenko commented Nov 9, 2017

@shoekstra here you are:-)

@shoekstra

This comment has been minimized.

Show comment
Hide comment
@shoekstra

shoekstra Nov 9, 2017

Contributor

I'll get started then 😃 Thanks!

Contributor

shoekstra commented Nov 9, 2017

I'll get started then 😃 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment