Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor library kex and cipher implementation #87

Closed
chris-rock opened this issue Apr 27, 2015 · 3 comments
Closed

refactor library kex and cipher implementation #87

chris-rock opened this issue Apr 27, 2015 · 3 comments
Assignees
@artem-sidorenko
Milestone
v2.0.0

Comments

@chris-rock
Copy link
Member

  • better structure
  • easier to upgrade ciphers to new os
  • reduce robocop abc metric
@chris-rock
Copy link
Member Author

should revert #86

@artem-sidorenko artem-sidorenko self-assigned this Nov 8, 2016
@artem-sidorenko
Copy link
Member

@chris-rock I guess we differentiate here between different OpenSSH versions. What about not to use the OS detection, but to use the openssh version in order to determine the supported ciphers?

We know the package name of openssh, and can get the version via information provided by ohai.

What do you think about this approach?

This was referenced Nov 9, 2016
Closed
Merged
@artem-sidorenko
Copy link
Member

me and @atomic111 agreed to push everything besides #132 to the 2.0.0, so I'm changing the milestone

@artem-sidorenko artem-sidorenko added this to the v2.0.0 milestone Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artem-sidorenko artem-sidorenko

Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@chris-rock @artem-sidorenko