New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor library kex and cipher implementation #87

Closed
chris-rock opened this Issue Apr 27, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@chris-rock
Member

chris-rock commented Apr 27, 2015

  • better structure
  • easier to upgrade ciphers to new os
  • reduce robocop abc metric
@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Apr 27, 2015

Member

should revert #86

Member

chris-rock commented Apr 27, 2015

should revert #86

@artem-sidorenko artem-sidorenko self-assigned this Nov 8, 2016

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Nov 8, 2016

Member

@chris-rock I guess we differentiate here between different OpenSSH versions. What about not to use the OS detection, but to use the openssh version in order to determine the supported ciphers?

We know the package name of openssh, and can get the version via information provided by ohai.

What do you think about this approach?

Member

artem-sidorenko commented Nov 8, 2016

@chris-rock I guess we differentiate here between different OpenSSH versions. What about not to use the OS detection, but to use the openssh version in order to determine the supported ciphers?

We know the package name of openssh, and can get the version via information provided by ohai.

What do you think about this approach?

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Nov 10, 2016

Member

me and @atomic111 agreed to push everything besides #132 to the 2.0.0, so I'm changing the milestone

Member

artem-sidorenko commented Nov 10, 2016

me and @atomic111 agreed to push everything besides #132 to the 2.0.0, so I'm changing the milestone

@artem-sidorenko artem-sidorenko added this to the v2.0.0 milestone Nov 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment