Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactoring of library to simplify the kex/cipher handling #134
This was referenced
Nov 10, 2016
changed the title from
WIP: Refactor the library to simplify the kex/cipher handling
Refactor the library to simplify the kex/cipher handling
Nov 23, 2016
@artem-sidorenko Thank you for the improvement. I apologize for the late review. I like your clean-up and and the improved version detection. I am not sure about the meta programing. Could you explain why we need it?
My first iteration was without it, I ended up with almost a same code for all functions
@chris-rock I already removed the metaprogramming implementation, so there is no open discussion point anymore.
Please let us proceed here, this PR is already open for 1 month and it blocks me on further progress in this cookbook.
Do you see any other points? Otherwise please tell me "LGTM" and I will squash&merge it and start to work on other tasks.