Removal of deprecated authorized_keys handling #143

Merged
merged 1 commit into from Dec 19, 2016

Conversation

Projects
None yet
3 participants
@artem-sidorenko
Member

artem-sidorenko commented Dec 17, 2016

Resolves #16

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 17, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 82a2a29 on artem-sidorenko:remove-deprecated-authorited-keys into d1f1bf1 on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 82a2a29 on artem-sidorenko:remove-deprecated-authorited-keys into d1f1bf1 on dev-sec:master.

@artem-sidorenko artem-sidorenko changed the title from Removal of deprecated authorized_keys handling to WIP: Removal of deprecated authorized_keys handling Dec 17, 2016

@artem-sidorenko artem-sidorenko changed the title from WIP: Removal of deprecated authorized_keys handling to Removal of deprecated authorized_keys handling Dec 17, 2016

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 17, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling f1445dc on artem-sidorenko:remove-deprecated-authorited-keys into d1f1bf1 on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling f1445dc on artem-sidorenko:remove-deprecated-authorited-keys into d1f1bf1 on dev-sec:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 17, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 6775dbc on artem-sidorenko:remove-deprecated-authorited-keys into d1f1bf1 on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 6775dbc on artem-sidorenko:remove-deprecated-authorited-keys into d1f1bf1 on dev-sec:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 17, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 4cac0c0 on artem-sidorenko:remove-deprecated-authorited-keys into d1f1bf1 on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 4cac0c0 on artem-sidorenko:remove-deprecated-authorited-keys into d1f1bf1 on dev-sec:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 17, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 76bf9c5 on artem-sidorenko:remove-deprecated-authorited-keys into d1f1bf1 on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 76bf9c5 on artem-sidorenko:remove-deprecated-authorited-keys into d1f1bf1 on dev-sec:master.

@atomic111

This comment has been minimized.

Show comment
Hide comment
@atomic111

atomic111 Dec 19, 2016

Member

@artem-sidorenko thanks for cleaning this. May be you should add a hint in the README.md for the users. how to handle the ssh-key deployment. What do you think?

Member

atomic111 commented Dec 19, 2016

@artem-sidorenko thanks for cleaning this. May be you should add a hint in the README.md for the users. how to handle the ssh-key deployment. What do you think?

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Dec 19, 2016

Member

@atomic111 I added a short notice that user/key handling are out-of-scope. I do not want to recommend any solution for user/key management, as it completely depends on the environment and particular needs (e.g. some manage keys/users via chef/puppet, in other setups you will see LDAP or IPA or even AD)

Member

artem-sidorenko commented Dec 19, 2016

@atomic111 I added a short notice that user/key handling are out-of-scope. I do not want to recommend any solution for user/key management, as it completely depends on the environment and particular needs (e.g. some manage keys/users via chef/puppet, in other setups you will see LDAP or IPA or even AD)

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Dec 19, 2016

Member

@atomic111 and the deprecation notice was > 2 years old. In case somebody used it in the past - there was enough time to thing about alternatives :-)

Member

artem-sidorenko commented Dec 19, 2016

@atomic111 and the deprecation notice was > 2 years old. In case somebody used it in the past - there was enough time to thing about alternatives :-)

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 19, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling a733ab2 on artem-sidorenko:remove-deprecated-authorited-keys into d1f1bf1 on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling a733ab2 on artem-sidorenko:remove-deprecated-authorited-keys into d1f1bf1 on dev-sec:master.

@atomic111 atomic111 self-requested a review Dec 19, 2016

@atomic111

This comment has been minimized.

Show comment
Hide comment
@atomic111

atomic111 Dec 19, 2016

Member

great, thank you

Member

atomic111 commented Dec 19, 2016

great, thank you

@atomic111 atomic111 merged commit bfb15e5 into dev-sec:master Dec 19, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@artem-sidorenko artem-sidorenko deleted the artem-forks:remove-deprecated-authorited-keys branch Dec 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment