New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute namespace ['ssh-hardening'] added #144

Merged
merged 1 commit into from Dec 19, 2016

Conversation

Projects
None yet
3 participants
@artem-sidorenko
Member

artem-sidorenko commented Dec 17, 2016

in order to avoid namespace collisions

Resolves #142

The deprecated attributes (node['ssh']['cbc_required']) got a namespace too. Please ignore that, I'm going to remove them a separate PR after this big namespace thing is merged

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 17, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 9919ab9 on artem-sidorenko:namespace into d1f1bf1 on dev-sec:master.

coveralls commented Dec 17, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 9919ab9 on artem-sidorenko:namespace into d1f1bf1 on dev-sec:master.

Attribute namespace ['ssh-hardening'] added
in order to avoid namespace collisions
@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko
Member

artem-sidorenko commented Dec 19, 2016

@atomic111 rebased

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 19, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 244ff5f on artem-sidorenko:namespace into bfb15e5 on dev-sec:master.

coveralls commented Dec 19, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 244ff5f on artem-sidorenko:namespace into bfb15e5 on dev-sec:master.

@atomic111

This comment has been minimized.

Show comment
Hide comment
@atomic111

atomic111 Dec 19, 2016

Member

@artem-sidorenko thanks for solving #142

Member

atomic111 commented Dec 19, 2016

@artem-sidorenko thanks for solving #142

@atomic111 atomic111 merged commit a592a92 into dev-sec:master Dec 19, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@artem-sidorenko artem-sidorenko deleted the artem-forks:namespace branch Dec 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment