Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: sshd listens on IPv6 interface if enabled #148

Merged
merged 1 commit into from
Jan 3, 2017

Conversation

artem-sidorenko
Copy link
Member

Fixes GH-140

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 617a550 on artem-sidorenko:ipv6 into c1fbf18 on dev-sec:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 617a550 on artem-sidorenko:ipv6 into c1fbf18 on dev-sec:master.

@atomic111
Copy link
Member

@artem-sidorenko can you add a list in the README.md for attribute-precedence. I think, it is easier for the user to find out the attributes he can manipulate.

@chris-rock
Copy link
Member

@artem-sidorenko Great addition. Could you rebase this to latest master?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8c77ce3 on artem-sidorenko:ipv6 into 04e0374 on dev-sec:master.

@artem-sidorenko
Copy link
Member Author

@chris-rock done
@atomic111 generally the user should use higher precedence level anyway. However sometimes you can find the attribute overriding on the same precedence level and the execution order. This won't work here and I just wanted to make it explicitly visible. I think its not cool to list/maintain a dedicated attribute list in the README. I've updated the notice in order to make the message more clear (hopefully)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5ef0115 on artem-sidorenko:ipv6 into 04e0374 on dev-sec:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5ef0115 on artem-sidorenko:ipv6 into 04e0374 on dev-sec:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 63ae489 on artem-sidorenko:ipv6 into 04e0374 on dev-sec:master.

@artem-sidorenko
Copy link
Member Author

@chris-rock now it should be fixed

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 75b4886 on artem-sidorenko:ipv6 into cfd4733 on dev-sec:master.

@artem-sidorenko
Copy link
Member Author

@atomic111 @chris-rock guys, maybe you to stop "thank you for this and that" in my direction in each issue/PR?:-) Its cool for new contributors, by for me its getting annoying somehow :-) it makes an impression of something like a rule to write "thank you" in each PR

@chris-rock
Copy link
Member

@artem-sidorenko Roger that. From now on, I'll give you harsh feedback only. :-)

@artem-sidorenko
Copy link
Member Author

@chris-rock it does not have to be harsh, neutral feedback is fair enough:)

@chris-rock
Copy link
Member

Haha, just kidding @artem-sidorenko

@atomic111
Copy link
Member

@artem-sidorenko thank you for your great work. you pushed a lot of improvements.

@artem-sidorenko
Copy link
Member Author

lol 👍

@chris-rock
Copy link
Member

@artem-sidorenko Are you going to rebase, so that we can merge this PR?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 03ca687 on artem-sidorenko:ipv6 into 941f1e7 on dev-sec:master.

@artem-sidorenko
Copy link
Member Author

@chris-rock done, please have a look

@chris-rock
Copy link
Member

Looks all good @artem-sidorenko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants