Bugfix: sshd listens on IPv6 interface if enabled #148

Merged
merged 1 commit into from Jan 3, 2017

Conversation

Projects
None yet
4 participants
@artem-sidorenko
Member

artem-sidorenko commented Dec 22, 2016

Fixes GH-140

@artem-sidorenko artem-sidorenko added the bug label Dec 22, 2016

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 22, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 617a550 on artem-sidorenko:ipv6 into c1fbf18 on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 617a550 on artem-sidorenko:ipv6 into c1fbf18 on dev-sec:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 22, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 617a550 on artem-sidorenko:ipv6 into c1fbf18 on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 617a550 on artem-sidorenko:ipv6 into c1fbf18 on dev-sec:master.

@atomic111

This comment has been minimized.

Show comment
Hide comment
@atomic111

atomic111 Dec 23, 2016

Member

@artem-sidorenko can you add a list in the README.md for attribute-precedence. I think, it is easier for the user to find out the attributes he can manipulate.

Member

atomic111 commented Dec 23, 2016

@artem-sidorenko can you add a list in the README.md for attribute-precedence. I think, it is easier for the user to find out the attributes he can manipulate.

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Dec 23, 2016

Member

@artem-sidorenko Great addition. Could you rebase this to latest master?

Member

chris-rock commented Dec 23, 2016

@artem-sidorenko Great addition. Could you rebase this to latest master?

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 23, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 8c77ce3 on artem-sidorenko:ipv6 into 04e0374 on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 8c77ce3 on artem-sidorenko:ipv6 into 04e0374 on dev-sec:master.

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Dec 23, 2016

Member

@chris-rock done
@atomic111 generally the user should use higher precedence level anyway. However sometimes you can find the attribute overriding on the same precedence level and the execution order. This won't work here and I just wanted to make it explicitly visible. I think its not cool to list/maintain a dedicated attribute list in the README. I've updated the notice in order to make the message more clear (hopefully)

Member

artem-sidorenko commented Dec 23, 2016

@chris-rock done
@atomic111 generally the user should use higher precedence level anyway. However sometimes you can find the attribute overriding on the same precedence level and the execution order. This won't work here and I just wanted to make it explicitly visible. I think its not cool to list/maintain a dedicated attribute list in the README. I've updated the notice in order to make the message more clear (hopefully)

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 23, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 5ef0115 on artem-sidorenko:ipv6 into 04e0374 on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 5ef0115 on artem-sidorenko:ipv6 into 04e0374 on dev-sec:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 23, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 5ef0115 on artem-sidorenko:ipv6 into 04e0374 on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 5ef0115 on artem-sidorenko:ipv6 into 04e0374 on dev-sec:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 23, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 63ae489 on artem-sidorenko:ipv6 into 04e0374 on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 63ae489 on artem-sidorenko:ipv6 into 04e0374 on dev-sec:master.

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Dec 23, 2016

Member

@chris-rock now it should be fixed

Member

artem-sidorenko commented Dec 23, 2016

@chris-rock now it should be fixed

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 23, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 75b4886 on artem-sidorenko:ipv6 into cfd4733 on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 75b4886 on artem-sidorenko:ipv6 into cfd4733 on dev-sec:master.

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Dec 23, 2016

Member

@atomic111 @chris-rock guys, maybe you to stop "thank you for this and that" in my direction in each issue/PR?:-) Its cool for new contributors, by for me its getting annoying somehow :-) it makes an impression of something like a rule to write "thank you" in each PR

Member

artem-sidorenko commented Dec 23, 2016

@atomic111 @chris-rock guys, maybe you to stop "thank you for this and that" in my direction in each issue/PR?:-) Its cool for new contributors, by for me its getting annoying somehow :-) it makes an impression of something like a rule to write "thank you" in each PR

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Dec 23, 2016

Member

@artem-sidorenko Roger that. From now on, I'll give you harsh feedback only. :-)

Member

chris-rock commented Dec 23, 2016

@artem-sidorenko Roger that. From now on, I'll give you harsh feedback only. :-)

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Dec 23, 2016

Member

@chris-rock it does not have to be harsh, neutral feedback is fair enough:)

Member

artem-sidorenko commented Dec 23, 2016

@chris-rock it does not have to be harsh, neutral feedback is fair enough:)

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Dec 23, 2016

Member

Haha, just kidding @artem-sidorenko

Member

chris-rock commented Dec 23, 2016

Haha, just kidding @artem-sidorenko

@atomic111

This comment has been minimized.

Show comment
Hide comment
@atomic111

atomic111 Dec 23, 2016

Member

@artem-sidorenko thank you for your great work. you pushed a lot of improvements.

Member

atomic111 commented Dec 23, 2016

@artem-sidorenko thank you for your great work. you pushed a lot of improvements.

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Dec 23, 2016

Member

lol 👍

Member

artem-sidorenko commented Dec 23, 2016

lol 👍

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Jan 3, 2017

Member

@artem-sidorenko Are you going to rebase, so that we can merge this PR?

Member

chris-rock commented Jan 3, 2017

@artem-sidorenko Are you going to rebase, so that we can merge this PR?

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 3, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 03ca687 on artem-sidorenko:ipv6 into 941f1e7 on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 03ca687 on artem-sidorenko:ipv6 into 941f1e7 on dev-sec:master.

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Jan 3, 2017

Member

@chris-rock done, please have a look

Member

artem-sidorenko commented Jan 3, 2017

@chris-rock done, please have a look

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Jan 3, 2017

Member

Looks all good @artem-sidorenko

Member

chris-rock commented Jan 3, 2017

Looks all good @artem-sidorenko

@chris-rock chris-rock merged commit 0a81810 into dev-sec:master Jan 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@artem-sidorenko artem-sidorenko deleted the artem-forks:ipv6 branch Jan 3, 2017

@artem-sidorenko artem-sidorenko removed the bug label Jan 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment