Improve the docs on the attribute overriding #156

Merged
merged 1 commit into from Jan 5, 2017

Conversation

Projects
None yet
4 participants
@artem-sidorenko
Member

artem-sidorenko commented Jan 4, 2017

Based on this feedback: #140 (comment)

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Jan 4, 2017

Member

@rjhornsby @atomic111 can you please have a look?

Member

artem-sidorenko commented Jan 4, 2017

@rjhornsby @atomic111 can you please have a look?

@rjhornsby

+1. looks good

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 4, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling e6d15ee on artem-sidorenko:docs into 0a81810 on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling e6d15ee on artem-sidorenko:docs into 0a81810 on dev-sec:master.

@atomic111

This comment has been minimized.

Show comment
Hide comment
@atomic111

atomic111 Jan 5, 2017

Member

@artem-sidorenko thanks for the doc improvement

Member

atomic111 commented Jan 5, 2017

@artem-sidorenko thanks for the doc improvement

@atomic111 atomic111 merged commit 5878040 into dev-sec:master Jan 5, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@artem-sidorenko artem-sidorenko deleted the artem-forks:docs branch Jan 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment