Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the docs on the attribute overriding #156

Merged
merged 1 commit into from
Jan 5, 2017
Merged

Improve the docs on the attribute overriding #156

merged 1 commit into from
Jan 5, 2017

Conversation

artem-sidorenko
Copy link
Member

Based on this feedback: #140 (comment)

@artem-sidorenko
Copy link
Member Author

@rjhornsby @atomic111 can you please have a look?

rjhornsby
rjhornsby approved these changes Jan 4, 2017
View reviewed changes
Copy link
Contributor

@rjhornsby rjhornsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. looks good

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e6d15ee on artem-sidorenko:docs into 0a81810 on dev-sec:master.

@atomic111
Copy link
Member

@artem-sidorenko thanks for the doc improvement

@atomic111 atomic111 merged commit 5878040 into dev-sec:master Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjhornsby rjhornsby rjhornsby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@artem-sidorenko @coveralls @atomic111 @rjhornsby