Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the docs on the attribute overriding #156

Merged
merged 1 commit into from Jan 5, 2017

Conversation

@artem-sidorenko
Copy link
Member

artem-sidorenko commented Jan 4, 2017

Based on this feedback: #140 (comment)

Based on this feedback: #140 (comment)
@artem-sidorenko

This comment has been minimized.

Copy link
Member Author

artem-sidorenko commented Jan 4, 2017

@rjhornsby @atomic111 can you please have a look?

Copy link

rjhornsby left a comment

+1. looks good

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 4, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling e6d15ee on artem-sidorenko:docs into 0a81810 on dev-sec:master.

@atomic111

This comment has been minimized.

Copy link
Member

atomic111 commented Jan 5, 2017

@artem-sidorenko thanks for the doc improvement

@atomic111 atomic111 merged commit 5878040 into dev-sec:master Jan 5, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@artem-sidorenko artem-sidorenko deleted the artem-forks:docs branch Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.