Avoid small primes for DH and allow rebuild of DH primes #163

Merged
merged 2 commits into from Jan 18, 2017

Conversation

Projects
None yet
3 participants
@artem-sidorenko
Member

artem-sidorenko commented Jan 14, 2017

Fixes GH-65

Related PR to the ssh-baseline with functional tests: dev-sec/ssh-baseline#77

We have two things in this PR (separated in different commits):

  • one thing is to remove the small primes
  • second thing is to allow rebuild of primes. This takes usually a lot of time and is therefore disabled per default

@artem-sidorenko artem-sidorenko added this to the v2.0.0 milestone Jan 14, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 14, 2017

Coverage Status

Coverage decreased (-0.2%) to 99.79% when pulling 1c3b104 on artem-sidorenko:dh-moduli into 5fa902c on dev-sec:master.

Coverage Status

Coverage decreased (-0.2%) to 99.79% when pulling 1c3b104 on artem-sidorenko:dh-moduli into 5fa902c on dev-sec:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 14, 2017

Coverage Status

Coverage decreased (-0.2%) to 99.791% when pulling 809a7f8 on artem-sidorenko:dh-moduli into 5fa902c on dev-sec:master.

Coverage Status

Coverage decreased (-0.2%) to 99.791% when pulling 809a7f8 on artem-sidorenko:dh-moduli into 5fa902c on dev-sec:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 14, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling a2fa759 on artem-sidorenko:dh-moduli into 5fa902c on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling a2fa759 on artem-sidorenko:dh-moduli into 5fa902c on dev-sec:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 14, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 8f10f45 on artem-sidorenko:dh-moduli into 5fa902c on dev-sec:master.

coveralls commented Jan 14, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 8f10f45 on artem-sidorenko:dh-moduli into 5fa902c on dev-sec:master.

@artem-sidorenko artem-sidorenko referenced this pull request in dev-sec/ssh-baseline Jan 14, 2017

Merged

Test the strong DH primes #77

@rndmh3ro rndmh3ro referenced this pull request in dev-sec/ansible-ssh-hardening Jan 18, 2017

Closed

Avoid small primes for DH and allow rebuild of DH primes #89

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Jan 18, 2017

Member

@atomic111 rebased as agreed

Member

artem-sidorenko commented Jan 18, 2017

@atomic111 rebased as agreed

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 18, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 74d0c6f on artem-sidorenko:dh-moduli into 94c08e7 on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 74d0c6f on artem-sidorenko:dh-moduli into 94c08e7 on dev-sec:master.

@atomic111

This comment has been minimized.

Show comment
Hide comment
@atomic111

atomic111 Jan 18, 2017

Member

@artem-sidorenko great!!! thank you

Member

atomic111 commented Jan 18, 2017

@artem-sidorenko great!!! thank you

@atomic111 atomic111 merged commit 29302d7 into dev-sec:master Jan 18, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@artem-sidorenko artem-sidorenko deleted the artem-forks:dh-moduli branch Jan 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment