Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of deprecated options for newer openssh versions #203

Merged
merged 5 commits into from
Oct 18, 2018

Conversation

artem-sidorenko
Copy link
Member

@artem-sidorenko artem-sidorenko commented Oct 16, 2018

Signed-off-by: Artem Sidorenko <artem@posteo.de>
Signed-off-by: Artem Sidorenko <artem@posteo.de>
should not be used for openssh >=7.4

Signed-off-by: Artem Sidorenko <artem@posteo.de>
for openssh >=7.5

Signed-off-by: Artem Sidorenko <artem@posteo.de>
Signed-off-by: Artem Sidorenko <artem@posteo.de>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 99.831% when pulling c9e58c2 on artem-forks:deprecations into f042bc0 on dev-sec:master.

Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement @artem-sidorenko

@@ -0,0 +1,7 @@
control 'sshd configuration should not have any deprecations' do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that something we should also test in the baseline?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this: baseline and ssh-hardening can be used independently, maybe somebody still has or wants to have deprecated options for some reasons? In the same time I wanted to ensure our template here is always up-to-date

@artem-sidorenko artem-sidorenko merged commit fb7a8f7 into dev-sec:master Oct 18, 2018
@artem-sidorenko artem-sidorenko deleted the deprecations branch October 18, 2018 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants