permit_tunnel attribute - allow tun device forwarding #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-sidorenko
requested changes
Nov 20, 2018
There was a problem hiding this comment.
@bobchaos thank you! it looks good for me, we need to fix some minor things:
- can you please sign-off your commit?
git commit --amend --signoff
git push --force
- can you please rebase the PR on the latest master to resolve the conflict?
https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request#perform-a-rebase
README.md
Outdated
| @@ -56,6 +56,7 @@ override['ssh-hardening']['ssh']['server']['listen_to'] = node['ipaddress'] | |||
| * `['ssh-hardening']['ssh']['server']['allow_tcp_forwarding']` - `false`. Set to `true` to allow TCP Forwarding | |||
| * `['ssh-hardening']['ssh']['server']['allow_agent_forwarding']` - `false`. Set to `true` to allow Agent Forwarding | |||
| * `['ssh-hardening']['ssh']['server']['allow_x11_forwarding']` - `false`. Set to `true` to allow X11 Forwarding | |||
| * `['ssh-hardening']['ssh']['server']['permit_tunnel']` - `false` to disable tun device forwarding. Set to `true` to allow tun device forwarding. Other accepted values: 'yes', 'no', 'point-to-point', 'ethernet', see man sshd\_config pages for exact behaviors. Do note you'll also need to allow TCP forwarding. | |||
There was a problem hiding this comment.
can you please change it this way in order to match the style of README.md:
* `['ssh-hardening']['ssh']['server']['permit_tunnel']` - `false`. Set to `true` to allow tun device forwarding. Other accepted values: 'yes', 'no', 'point-to-point', 'ethernet', see `man sshd_config` for more details. Note: `allow_tcp_forwarding` should be enabled together with this option.Something like this?
artem-sidorenko
requested changes
Nov 20, 2018
artem-sidorenko
requested changes
Nov 20, 2018
There was a problem hiding this comment.
@bobchaos this looks very good! Thanks!
If you would make rubocop happy and (optionally) squash your commits (but only your commits) to one commit (to avoid fixup commits to previsious commits) we are ready to merge! And you can be proud of a very good PR with usage of advanced git features ;-)
|
fixed and squashed! |
as requested by @artem-sidorenko
Signed-off-by: Marc Chamberland <mchamberland@pbsc.com>
somehow the exception is not really catched, maybe because of the lazy execution somehow.
If expect is called in the usual way with () instead of {} you see the exception. Weird thing.
Signed-off-by: Artem Sidorenko <artem@posteo.de>
artem-sidorenko
approved these changes
Nov 21, 2018
artem-sidorenko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.