update to chefspec 4.1.1 #45

Merged
merged 7 commits into from Oct 13, 2014

Conversation

Projects
None yet
3 participants
@bkw
Contributor

bkw commented Oct 13, 2014

syntax updated to use the new chefspec-4.1.0 way of doing things, no functional changes.

  • update chefspec and chef dependencies (chefspec-4.1.0 needs at least chef 11.14)
  • remove deprecated explicit require of chefspec/server
  • change ChefSpec::Runner into ChefSpec::ServerRunner
  • construct data bags inside of chef_run block

For details, see https://github.com/sethvargo/chefspec/blob/master/CHANGELOG.md

@bkw

This comment has been minimized.

Show comment
Hide comment
@bkw

bkw Oct 13, 2014

Contributor

rebased for current master

Contributor

bkw commented Oct 13, 2014

rebased for current master

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 13, 2014

Coverage Status

Coverage decreased (-1.08%) when pulling 2897394 on bkw:chefspec-4.1.0 into 7ab4273 on TelekomLabs:master.

Coverage Status

Coverage decreased (-1.08%) when pulling 2897394 on bkw:chefspec-4.1.0 into 7ab4273 on TelekomLabs:master.

@bkw

This comment has been minimized.

Show comment
Hide comment
@bkw

bkw Oct 13, 2014

Contributor

seems coveralls and chefspec-4.1.0 don't play nicely together just yet. Bummer.

Contributor

bkw commented Oct 13, 2014

seems coveralls and chefspec-4.1.0 don't play nicely together just yet. Bummer.

@bkw

This comment has been minimized.

Show comment
Hide comment
@bkw

bkw Oct 13, 2014

Contributor

I created chefspec/chefspec#504 for this, in case it really is a chefspec issue.

Contributor

bkw commented Oct 13, 2014

I created chefspec/chefspec#504 for this, in case it really is a chefspec issue.

@bkw bkw added the invalid label Oct 13, 2014

@bkw bkw removed the invalid label Oct 13, 2014

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 13, 2014

Coverage Status

Coverage remained the same when pulling 3922d31 on bkw:chefspec-4.1.0 into 7ab4273 on TelekomLabs:master.

Coverage Status

Coverage remained the same when pulling 3922d31 on bkw:chefspec-4.1.0 into 7ab4273 on TelekomLabs:master.

@bkw bkw changed the title from update to chefspec 4.1.0 to update to chefspec 4.1.1 Oct 13, 2014

@bkw

This comment has been minimized.

Show comment
Hide comment
@bkw

bkw Oct 13, 2014

Contributor

Thanks to @sethvargo himself, this thing can now be merged. Yay!

Contributor

bkw commented Oct 13, 2014

Thanks to @sethvargo himself, this thing can now be merged. Yay!

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Oct 13, 2014

Member

that is amazing @bkw

Member

chris-rock commented Oct 13, 2014

that is amazing @bkw

chris-rock added a commit that referenced this pull request Oct 13, 2014

Merge pull request #45 from bkw/chefspec-4.1.0
update to chefspec 4.1.1

@chris-rock chris-rock merged commit 54ff658 into dev-sec:master Oct 13, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@bkw

This comment has been minimized.

Show comment
Hide comment
@bkw

bkw Oct 13, 2014

Contributor

Thanks for merging! <3

Contributor

bkw commented Oct 13, 2014

Thanks for merging! <3

@bkw bkw deleted the bkw:chefspec-4.1.0 branch Oct 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment