Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make UseDNS configurable #80
added a commit
this pull request
Apr 27, 2015
I guess I could do the same as
Also, I only added local rspec tests, they did not seem to be run when using `kitchen test default-ubuntu-1204, should I add them to the shared spec repo or how exactly do you guys maintain these?
@aried3r Thanks for adding the rspecs :) You're right, they don't run with kitchen test; We typically run them via
Let's see if the defaults for UseDNS have security implications. If not, I'd prefer the solution of only setting it, if the user assigns a value. With the cookbook supporting more options, I think it's best to use this style of configuration.
If you use