Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern alogs for Jessie #83

Merged
merged 1 commit into from
Apr 27, 2015
Merged

Modern alogs for Jessie #83

merged 1 commit into from
Apr 27, 2015

Conversation

Rockstar04
Copy link
Member

Should be the exact equivalent changes made to the puppet repo. closes #77

Also should we look into chefspec tests for those helpers, or just let serverspec cover it?

@chris-rock
Copy link
Member

great work @Rockstar04 we need to get #84 through first

@Rockstar04
Copy link
Member Author

I'm not sure what the proper Ruby way would be to restructure the "Assignment Branch Condition size for xxxx is too high." warnings that are stopping Travis.

@chris-rock
Copy link
Member

this is a robocop error message. See https://github.com/bbatsov/rubocop/blob/master/lib/rubocop/cop/metrics/abc_size.rb

this is configured in: https://github.com/hardening-io/chef-ssh-hardening/blob/master/.rubocop.yml#L28

You can test this locally by using rake lint

@chris-rock chris-rock mentioned this pull request Apr 27, 2015
@Rockstar04
Copy link
Member Author

Sorry, I understood what the rubocop error was telling me, I am just unsure what the proper way to go about refactoring into something better

@arlimus
Copy link
Member

arlimus commented Apr 27, 2015

@Rockstar04 thank you for adding Debian 8! :)

Regarding Rubocop: That ABC-linter points to some restructuring in the function. Mid-term we may as well increase this value, as in this case the coding-style that contributes to the error (those many assignments) is a matter of style and not complexity.

I re-ran all specs and lints; specs are clean, lint only shows Abc-error. Let's fix it in an upcoming commit.

Cheers

arlimus added a commit that referenced this pull request Apr 27, 2015
@arlimus arlimus merged commit 887e72d into dev-sec:master Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debian 8.0 (Jessie) ships with OpenSSH 6.7p1, enable modern algos
3 participants