Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cron permissions hardening #150

Merged
merged 2 commits into from Feb 22, 2021
Merged

add cron permissions hardening #150

merged 2 commits into from Feb 22, 2021

Conversation

rndmh3ro
Copy link
Member

No description provided.

@rndmh3ro rndmh3ro mentioned this pull request Feb 22, 2021
Merged
Add empty line after guard clause
559b167 
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
@micheelengronne
Copy link
Member

I like the check if file exists. It is usefull in container when cron is not present. LGTM

@rndmh3ro rndmh3ro merged commit 11e04dd into master Feb 22, 2021
micheelengronne
micheelengronne reviewed Feb 22, 2021
View reviewed changes
Copy link
Member

@micheelengronne micheelengronne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcgege mcgege mentioned this pull request Feb 24, 2021
Merged
@rndmh3ro rndmh3ro deleted the cron branch February 26, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micheelengronne micheelengronne micheelengronne left review comments

@schurzi schurzi schurzi approved these changes

@chris-rock chris-rock Awaiting requested review from chris-rock

Assignees
No one assigned
Labels
enhancement minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rndmh3ro @micheelengronne @schurzi