On SUSE environments 'auditd' is part of package 'audit' #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
reviewed
Jun 26, 2017
There was a problem hiding this comment.
@mcgege Thank you for that improvement. I left a mini change request
controls/package_spec.rb
Outdated
| @@ -80,7 +80,7 @@ | |||
| impact 1.0 | |||
| title 'Install auditd' | |||
| desc 'auditd provides extended logging capacities on recent distribution' | |||
| audit_pkg = os.redhat? ? 'audit' : 'auditd' | |||
| audit_pkg = (os.redhat? or os.suse?) ? 'audit' : 'auditd' | |||
There was a problem hiding this comment.
Let's use
(os.redhat? || os.suse?)
artem-sidorenko
requested changes
Jun 26, 2017
There was a problem hiding this comment.
@mcgege thanks for this PR, looks good to me
Can you please make the rubocop happy?
|
Uhh, tried to make rubocop happy, but it is very picky ... any ideas? |
|
@mcgege You can run |
|
Google is your friend on error messages ... |
artem-sidorenko
approved these changes
Jun 26, 2017
|
@mcgege thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.