Check for Amazon Linux when determining audit package. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
requested changes
Jul 13, 2017
There was a problem hiding this comment.
@HenryTheHamster Awesome, thank you for your contribution. Could you please sign-off the commit too?
controls/package_spec.rb
Outdated
| @@ -80,7 +80,7 @@ | |||
| impact 1.0 | |||
| title 'Install auditd' | |||
| desc 'auditd provides extended logging capacities on recent distribution' | |||
| audit_pkg = os.redhat? || os.suse? ? 'audit' : 'auditd' | |||
| audit_pkg = os.redhat? || os.suse? || os.family == 'amazon' ? 'audit' : 'auditd' | |||
There was a problem hiding this comment.
InSpec is going to use the helper like linux? or windows? for family. Lets use os.name == 'amazon' here
Signed-off-by: andy shaw <shawry@shawry.com>
|
Hi @chris-rock, thanks for the input. Is there anything more required for this to be merged? Cheers! |
atomic111
approved these changes
Aug 10, 2017
chris-rock
approved these changes
Aug 10, 2017
|
Fixes #79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been running against Amazon Linux, and while all the audit config is detected fine, the package controls are looking for the auditd package and failing.