add logdir-check #81
Merged
add logdir-check #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rndmh3ro thanks! I'll test it together with chef this week |
artem-sidorenko
requested changes
Sep 20, 2017
controls/os_spec.rb
Outdated
| @@ -17,6 +17,13 @@ | |||
| # author: Dominik Richter | |||
| # author: Patrick Muench | |||
|
|
|||
| when 'ubuntu', 'debian' | |||
There was a problem hiding this comment.
@rndmh3ro here is a syntax error, probably you mean something like:
log_dir_group = case os[:family]
when 'debian', 'redhat', 'fedora'
'root'
when 'ubuntu'
os[:release] == '14.04' ? 'syslog' : 'root'
end
controls/os_spec.rb
Outdated
| @@ -235,4 +242,13 @@ | |||
| its(:content) { should match 'install udf /bin/true' } | |||
| its(:content) { should match 'install vfat /bin/true' } | |||
| end | |||
There was a problem hiding this comment.
one end and empty line are missing here
|
Totally forgot about this one, sorry. |
artem-sidorenko
approved these changes
Oct 31, 2017
|
@rndmh3ro Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we remove it here: dev-sec/mysql-baseline#38