fix virtualization usage in older inspec versions #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This profile throws an exception when using InSpec < 2.0.30 on non-virtualized systems because this fix (inspec/inspec#2603) was not included in prior versions. This pull simply catches the exception where virtualization.* is called in pure Ruby.
|
@mattlqx Nice catch. What do you think about adding a minimum inspec version into the inspec.yml instead? |
|
Pinning to a newer version wouldn't help me out where I'm running older versions of Automate and ChefDK because of other compatibility/product issues. I suspect there are others in the same situation. If you don't want to go with catching the NoMethodError, from what I understand if the |
|
Got ya. That makes sense for now. Would love to understand the compatibility issues better, since we may need to add some additional capability to InSpec or Automate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This profile throws an exception when using InSpec < 2.0.30 on non-virtualized systems because this fix (inspec/inspec#2603) was not included in prior versions. This pull simply catches the exception where virtualization.* is called in pure Ruby.
Older versions are still very much alive in bundles of Chef Automate 1.x and ChefDK 2.x and are difficult to upgrade ad-hoc.