Declare control source as UTF-8 encoding. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dev-sec#33 There are a number of issues open and closed for encoding in InSpec profiles https://github.com/inspec/inspec/issues?utf8=%E2%9C%93&q=is%3Aissue+encoding To work in all versions of InSpec currently supported, this profile should keep the `# encoding: UTF-8` declaration. Signed-off-by: James Stocks <jstocks@chef.io>
|
This commit doesn't make sense to me. Someone want to give me some background? Ruby's default internal encoding has been UTF-8 since 2.0. |
|
This is really a bug in InSpec that we mitigate here. Therefore you should better ask there. |
|
I'm on inspec, which is why I'm asking... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
There are a number of issues open and closed for encoding in InSpec profiles https://github.com/inspec/inspec/issues?utf8=%E2%9C%93&q=is%3Aissue+encoding
To work in all versions of InSpec currently supported, this profile should keep the
# encoding: UTF-8declaration.Signed-off-by: James Stocks jstocks@chef.io