Change default: to value: #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Enzo Mignogna <enzo.mignogna@avature.net>
micheelengronne
requested changes
Jul 13, 2020
controls/nginx_spec.rb
Outdated
| @@ -190,7 +190,7 @@ | |||
| title 'Control simultaneous connections' | |||
| desc 'NginxHttpLimitZone module to limit the number of simultaneous connections for the assigned session or as a special case, from one IP address.' | |||
| describe parse_config(nginx_parsed_config, options) do | |||
| its('limit_conn_zone') { should eq '$binary_remote_addr zone=default:10m' } | |||
| its('limit_conn_zone') { should eq '$binary_remote_addr zone=value:10m' } | |||
There was a problem hiding this comment.
That one is not an Inspec variable but an nginx configuration. I think it should stay to default.
Signed-off-by: Enzo Mignogna <enzo.mignogna@avature.net>
micheelengronne
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like to reduce WARN: DEPRECATION regarding default:
Value of default: was changed to value:
Signed-off-by: Enzo Mignogna enzo.mignogna@avature.net