Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to InSpec #13

Merged
merged 4 commits into from
Jan 5, 2017
Merged

Migrate to InSpec #13

merged 4 commits into from
Jan 5, 2017

Conversation

atomic111
Copy link
Member

No description provided.

Signed-off-by: Patrick Münch <patrick.muench1111@gmail.com>
Signed-off-by: Patrick Münch <patrick.muench1111@gmail.com>
Signed-off-by: Patrick Münch <patrick.muench1111@gmail.com>
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atomic111 Awesome work. Especially, you put a lot of effort in writing all the controls! Wow.

@@ -0,0 +1,10 @@
name: postgres-hardening
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should align this with our new wording: postgres-baseline

copyright_email: hello@dev-sec.io
license: Apache 2 license
summary: Test-suite for best-practice postgres hardening
version: 0.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should bump it to version 2.0.0 since 1.x is the Serverspec-based implementation

# attributes

DB_USER = attribute(
'db_user',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just stick to user and password?

@chris-rock
Copy link
Member

@atomic111 should we go forward and merge this PR? We could fix issues in further PRs? Do you have a list of points that is missing before the migration is complete?

@chris-rock chris-rock changed the title WIP: migrate to inspec Migrate to InSpec Jan 4, 2017
@chris-rock
Copy link
Member

This profile works well with the latest version of InSpec. It depends on inspec/inspec#826 and inspec/inspec#1395 to work properly:

screen shot 2017-01-03 at 6 53 15 pm

Awesome work @atomic111

Signed-off-by: Patrick Münch <patrick.muench1111@gmail.com>

add postgres test 1 to 9

Signed-off-by: Patrick Münch <patrick.muench1111@gmail.com>

add inspec attributes POSTGRES_CONF_DIR and POSTGRES_CONF_PATH, add test 10 to 12

Signed-off-by: Patrick Münch <patrick.muench1111@gmail.com>

add test 12

Signed-off-by: Patrick Münch <patrick.muench1111@gmail.com>

added new postgres test

Signed-off-by: Patrick Münch <patrick.muench1111@gmail.com>

add license

Signed-off-by: Patrick Münch <patrick.muench1111@gmail.com>

update gemfile, travis, rakefile

Signed-off-by: Patrick Münch <patrick.muench1111@gmail.com>

change Metrics/BlockLength in rubocop

Signed-off-by: Patrick Münch <patrick.muench1111@gmail.com>

change name and version bump

Signed-off-by: Patrick Münch <patrick.muench1111@gmail.com>

rename inspec attribute db_user to user and db_password to password

Signed-off-by: Patrick Münch <patrick.muench1111@gmail.com>
@atomic111
Copy link
Member Author

@chris-rock thank you for the bugfix and now we can merge it. great!!!

@chris-rock
Copy link
Member

Thank you for this huge update @atomic111

@chris-rock chris-rock merged commit 648c81b into dev-sec:master Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants