Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip entropy tests and disable auditd tests #117

Merged
merged 1 commit into from
Jan 16, 2018
Merged

Conversation

artem-sidorenko
Copy link
Member

basically just the copy&paste from chef-os-hardening

basically just the copy&paste from chef-os-hardening
include_controls 'linux-baseline' do
# skip entropy test, as our short living test VMs usually do not
# have enough
skip_control 'os-08'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as an alternative: I install the haveged package on all my systems to feed the random devices ... would it be possible to start this daemon also in the testing vm's?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcgege should we make it for testing only? Or should it be a general part of implementations?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I think it won't harm to implement it as a general solution, but there might be other ways to solve this out there. This is just my recommendation to be compliant here ...
Could this be easily implemented for testing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to go with haveged way: its possible, however the code isn't really two lines of code. For CentOS haveged is located within EPEL, so we need to install epel-release on RH family (and only on RH, so its an additional check) and so on. I personally would like to keep the skip_control way, as the haveged implementation is much more bigger. Is it okay for you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course it is!

@mcgege mcgege added this to the 2.1.0 milestone Jan 14, 2018
@mcgege mcgege merged commit 6d04089 into master Jan 16, 2018
@mcgege mcgege deleted the fix-some-tests branch February 27, 2018 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants