Update module metadata #97
Conversation
|
Maybe we should also include |
|
@artem-sidorenko @bitvijays What do you think about this? |
There was a problem hiding this comment.
@mcgege thanks! Regarding operatingsystem_support, here is the similar list from chef-os-hardening. Basically this list represents what we are testing in the CI. As we do not have automated integration tests here yet, not sure what should be there. For me it looks like you did a lot of changes for RHEL, Suse, Ubuntu. So puppet-os-hardening should run there, right?
Regarding the release of puppet-os-hardening, let us review/merge all your PRs first and then push the new release. @bitvijays can you handle the release process to puppet forge? @chris-rock can you add @bitvijays on the puppet forge? Or it should be done by @arlimus ?
@vjeffrey I can't really review it as I do not know the current puppet standards on this. Can you maybe have a look?
|
@artem-sidorenko I can confirm OpenSUSE 42.1 & 42.2, SLES 12, CentOS 7, Ubuntu 14.04 & 16.04. RHEL 7 should also work, as it is similar to CentOS 7. For other distros + versions, we could either implement #79 or guess based on our expirience :-) |
|
@artem-sidorenko Ok, I just added the OS versions |
|
@stefanbethke it would be cool if you could review this one if you like/can |
|
I agree that listing OSes implies that some validation has taken place that the module will work on those releases. For the time being, I'd only list the ones that can be verified by automated or manual tests, which should be documented. |
|
@stefanbethke right, they are all verified by @mcgege manually as we do not have automated testing here yet (#79), so it should be Okay I think. Can you maybe review the metadata, can we merge this PR? |
metadata.json
Outdated
| "requirements": [ | ||
| { | ||
| "name": "puppet", | ||
| "version_requirement": ">= 3.0.0 < 5.0.0" |
There was a problem hiding this comment.
I just checked my agent versions - with the last upgrade on Puppet Enterprise I partly rolled out puppet agent v5, so I think I could raise this to < 6.0.0
| { | ||
| "operatingsystem": "CentOS", | ||
| "operatingsystemrelease": [ | ||
| "7" |
There was a problem hiding this comment.
Well, I didn't test it with CentOS 6 ... it should work, but I cannot prove it.
metadata.json
Outdated
| "operatingsystem": "OpenSuSE", | ||
| "operatingsystemrelease": [ | ||
| "13", | ||
| "42" |
There was a problem hiding this comment.
Hmmm ... somehow my spaces were converted to a tab ... will correct this :-|
metadata.json
Outdated
| "operatingsystem": "Ubuntu", | ||
| "operatingsystemrelease": [ | ||
| "14", | ||
| "16" |
Rewrite of metadata.json based on https://docs.puppet.com/puppet/4.10/modules_metadata.html Signed-off-by: Michael Geiger <michael.geiger@telekom.de>
|
@artem-sidorenko How should we proceed here? |
|
Lets merge it, if we face any problems - we should fix them in other PRs @mcgege thanks for your patience! We should also release a new version on puppet forge, @chris-rock how can we do that from your POV? Do you have the credentials/access to puppet forge? |
Rewrite of metadata.json based on https://docs.puppet.com/puppet/4.10/modules_metadata.html
Signed-off-by: Michael Geiger michael.geiger@telekom.de