Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 139 - Use cmp instead of be matcher to allow string matching #140

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Issue 139 - Use cmp instead of be matcher to allow string matching #140

merged 1 commit into from
Aug 27, 2019

Conversation

chbiel
Copy link
Contributor

@chbiel chbiel commented Aug 27, 2019

@chbiel
Issue 139 - Use cmp instead of be matcher to allow string matching (#139
1676d11 
)

Signed-off-by: Christopher Biel <christopher.biel89@gmail.com>
@chbiel
Copy link
Contributor Author

chbiel commented Aug 27, 2019

Tested in our pipeline already

chris-rock
chris-rock approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix @chbiel

@chris-rock chris-rock merged commit 6a2c90f into dev-sec:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-rock chris-rock chris-rock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chbiel @chris-rock