feature(frontmatter description 노출 기능) #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 기존 frontmatter의 description은 블로그 목록에 표기되지 않는다. - graphql로 frontmatter의 description 속성을 함께 받아와서 존재 여부에 따른 노출 기능이 필요하다. 추가 이슈 - 같은 스타일을 가진 속성이기 때문에 컴포넌트 네이밍에 대한 고민이 필요한 것 같습니다. (SecondaryText?) - 혹은, 두 컴포넌트로 분리시키는 방안도 좋을 것 같습니다. 그 이유는 excerpt는 200자 줄임으로 명시되어 있으나, description은 제한이 없을 것 같습니다. (description에 200자를 넣는 것이 쉬운 일은 아니지만...)
devHudi
approved these changes
Jun 19, 2023
src/components/PostList/index.jsx
Outdated
| <Excerpt>{excerpt}</Excerpt> | ||
| { description | ||
| ? <Excerpt>{description}</Excerpt> | ||
| : <Excerpt>{excerpt}</Excerpt> |
There was a problem hiding this comment.
excerpt 는 GraphQL 단에서 길이 제한이 되어 불러와지는데, description 은 그게 아닐거라서 적절한 length 에서 끊어 보여주는게 좋을 것 같네요 👍👍 요 부분은 가능하면 제가 작업하겠습니다.
|
prettier 적용은 제가 해두었습니다 😄 (github actions CI가 돌려면 제 허가가 필요하네요 ㅎㅎ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related Links
고민