Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change FilterOutCommonParams to global #27

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Change FilterOutCommonParams to global #27

merged 1 commit into from
Nov 9, 2021

Conversation

HeyItsGilbert
Copy link
Contributor

@HeyItsGilbert HeyItsGilbert commented Oct 20, 2021

Minor tweak to FilterOutCommonParams to be global.

Description

Pester isn't picking up the script level function. The global function should resolve that.

Related Issue

#26

Motivation and Context

This well let Pester 5 find it.

How Has This Been Tested?

This test is included on the repo so I'm hoping the CI on the PR will validate it.
I use it currently for https://github.com/HeyItsGilbert/RPGDice/blob/main/tests/Help.tests.ps1#L5

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@brettmillerb
Copy link

I built @HeyItsGilbert fork of Stucco then build a test module from that and the tests were all passing on the newly scaffolded module so it would appear the scope of the FilterOutCommonParams is the issue here.

Cheers for this Gilbert 🎉

@HeyItsGilbert
Copy link
Contributor Author

@devblackops anything else I need to do? I also didn't know where to find the "CONTRIBUTING" document.

@devblackops
Copy link
Owner

Thanks @HeyItsGilbert!

@devblackops devblackops merged commit 2f45f71 into devblackops:main Nov 9, 2021
@devblackops devblackops mentioned this pull request Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants