Fix a number of issues with Watchmen #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues: * UseSSL switch for EMail notifier was hardcoded ($true) * Custom Message attribute for EMail notifier didn't get sent * Placeholders in LogFile notifier didn't get replaced (contrary to the project's README.md) Adds a ConvertFrom-PlaceholderString function to clean up redundant code and make the placeholder system more useful.
|
Thanks for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a ConvertFrom-PlaceholderString function to clean up redundant code and makes the
placeholder system more useful. Resolves a number of issues with Email and Logfile notifiers.
Related Issue
Issues:
Motivation and Context
See above
How Has This Been Tested?
Manual testing, haven't had the chance to run psake yet. Appveyor will take care of that for me though.
Types of changes
Checklist: