Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS support for downloading receiver files - Bounty: 10M DVC #77

Closed
Traxo7 opened this issue Oct 28, 2019 · 19 comments
Closed

HTTPS support for downloading receiver files - Bounty: 10M DVC #77

Traxo7 opened this issue Oct 28, 2019 · 19 comments
Assignees

Comments

@Traxo7
Copy link

Traxo7 commented Oct 28, 2019

Does daemon try to reach receiver files via https, or http? As one of the custodians is successfully listed as an IP address instead of a domain, I presumed issuing an SSL is not required (as SSL is probably not even allowed to be issued to IP addresses in the first place, or at least it might be a struggle to set up?).
In other words, should receiver file be reachable via https://... in addition to http://... ?

@develCuy
Copy link
Contributor

There is support for https but the source code support is very outdated so it is not able to download anything from https. For that reason, we only list http hosts. We need to updated the source code with the most recent ssl libraries so that https can work. Also, this will allow us to host receiver files in many free public mirrors (i.e: github, gitlab, bitbacket, etc.), along the existing custodians, for ensuring resilience.

@develCuy develCuy changed the title Is file custodian required to upgrade to https? HTTPS suppport for downloading receiver files Oct 28, 2019
@develCuy develCuy changed the title HTTPS suppport for downloading receiver files HTTPS suppport for downloading receiver files (50M DVC reward) Oct 28, 2019
@develCuy
Copy link
Contributor

develCuy commented Oct 28, 2019

UPDATE
Bounty reduced to 10M DVC see: #77 (comment)

ORIGINAL

Bounty
Since it is critical to have a reliable set of receiver files mirrors, I set a bounty of 50 million DVC from the DevFund to be distributed among all the people that work to fix this issue. The tester assigned is Qtera, which should certify the fix.

@develCuy
Copy link
Contributor

Block 396000 (round 99) was found on 2019-10-26 11:07:49 and this is the record of custodians reporting sync:
(all dates are UTC)

2019-10-22 03:51:08 Custodian 1
2019-10-22 06:21:38 Custodian 2
2019-10-23 13:21:37 Custodian 3
2019-10-23 17:04:45 Custodian 4
2019-10-26 09:07:47 Custodian 5

Also Custodian 6 didn't report back, but http://devcoin.darkgamex.ch reports file creation date:

2019-10-22 05:49 Custodian 6

Custodian 7 never synced and now is offline.

I checked each mirror as custodians reported. Custodian 3 was working by then, it was not working for me on Oct 27th. If we discard Custodian 3 for not being reliable we still had 4 mirrors ready when Custodian 4 synced on 2019-10-23 17:04:45.

In conclusion, we had the custodians well setup 2 days and 18 hours in advance to round 99. Yet, we should define a safe deadline for syncing custodians.

@develCuy
Copy link
Contributor

sawa reported a syncing issue with receiver 99 on https://bitcointalk.org/index.php?topic=233997.msg52886290#msg52886290

After starting the daemon, this message is displayed in the console:

Number of pages in getCommonOutputByText: 7
Insufficient identical pages in getCommonOutputByText.
Warning, writeFileText in receiver.h won't write the file:
/home/user/.devcoin/receiver/receiver_99.csv
because the text is blank.

@develCuy
Copy link
Contributor

develCuy commented Oct 28, 2019

@develCuy develCuy changed the title HTTPS suppport for downloading receiver files (50M DVC reward) HTTPS suppport for downloading receiver files - Bounty: 50M DVC Oct 28, 2019
@develCuy develCuy changed the title HTTPS suppport for downloading receiver files - Bounty: 50M DVC HTTPS suppport for downloading receiver files - Bounty: 10M DVC Oct 31, 2019
@develCuy
Copy link
Contributor

develCuy commented Oct 31, 2019

I figured out the fix faster than expected, so we don't need a big reward. Still, we have to test the fix extensively and release a new version of Devcoin! For that reason I change the bounty to 10M DVC from the DevFund to be distributed among all the people that work on fixing this issue. The tester assigned is @cpsilent, which should certify the fix.

@develCuy
Copy link
Contributor

develCuy commented Nov 7, 2019

@cpsilent we are going to use the testnet for this. You have to start devcoin with the -testnet param or just add "testnet=1" to your devcoin.conf file

@cpsilent
Copy link

cpsilent commented Nov 7, 2019

It seems opening the wallet with the testnet parameter was unable to sync the blockchain.

I used this guide to compile it: https://steemit.com/busy/@cpol/how-to-compile-your-very-own-devcoin-wallet-in-ubuntu-18-04

First, I downloaded the current source code from git using the command: git clone https://github.com/devcoin/core.git

The resulting compiled code version was this:

  • Client version: v0.8.6.0-g25a7d46-beta
  • Using OpenSSL version: OpenSSL 1.1.1 11 Sep 2018
  • Build date: 2019-11-05 11:00:48 -0500
  • Number of connections: 0
  • On testnet: checked
  • Current number of blocks, Estimated total blocks and last block time: N/A

As you can see in this first image, it began acquiring the blockchain at 8:21 but by 9:11 it kept stuck on 432 weeks
wallet01

Then, I added my personal wallet and started it again at 9:17 but by 9:47 it remained stuck
wallet02

I checked the previous compiled version (v0.8.5.1-g25a7d46-beta, 31st Oct 2019) without the testnet param and it synced properly. I waited around an hour and initiated the v0.8.6.0-g25a7d46-beta version without the testnet param and this time it synced properly. I tried also the v0.8.5.1-g25a7d46-beta version with the testnet param enabled with no blockchain syncing.

I saw that the testnet version made its own directory (testnet3) and it recreated all the files as you can see in the pictures, but it can't sync their blockchain at all. t seems there's something wrong with my testnet. I can try to compile it with docker instead but I think this has to do with something else but I'm not sure what could it be.

@develCuy
Copy link
Contributor

develCuy commented Nov 7, 2019

OK, our testnet is officially broken then. Please report the issue, I'll set a 1M DVC bounty for it

@cpsilent
Copy link

cpsilent commented Nov 7, 2019

Done @develCuy!

@develCuy
Copy link
Contributor

Quick update, according to https://chainz.cryptoid.info/dvc/#!network we still have few nodes able to support https (version 0.8.6 and up), so we should keep waiting to mark this issue resolved:

image

@develCuy
Copy link
Contributor

develCuy commented Nov 25, 2021

Good news! HTTPS support available in the majority of Devcoin Blockchain network:
image

Time to switch custodians to https

@develCuy develCuy changed the title HTTPS suppport for downloading receiver files - Bounty: 10M DVC HTTPS support for downloading receiver files - Bounty: 10M DVC Dec 9, 2021
@develCuy
Copy link
Contributor

develCuy commented Dec 9, 2021

Status:

  • Custodians ready ... check
  • New Binaries available ... check
  • People updating their wallets ... in progress

@Satoshi0x
Copy link

Satoshi0x commented Dec 10, 2021 via email

@develCuy
Copy link
Contributor

Full HTTPS support is finally working!

image

@cpsilent can you confirm that latest release is syncing beyond block 500000?

@cpsilent
Copy link

Full HTTPS support is finally working!

image

@cpsilent can you confirm that latest release is syncing beyond block 500000?

I opened the wallet and synced perfectly. Below there's a screen capture showing the receiver_125.csv. Can I run it differently to show you a more scientific prove? I synced the wallet before doing the screen capture, unfortunately. Maybe with a debug command or something? From my end it looks pretty fine!

receiver 125

@develCuy
Copy link
Contributor

Thanks for reporting @cpsilent, can you confirm your DVC address for bounty payment?

@cpsilent
Copy link

Thanks for reporting @cpsilent, can you confirm your DVC address for bounty payment?

Sure thing, my DVC address is 14BL4enKz7LVbgVPQPQ3PUvETm58SA3Q8g Thank you!

@develCuy
Copy link
Contributor

This is how the reward has been distributed among contributors:

Developer: 90% * 10M DVC => 9,000,000.00 DVC paid to @develCuy's address 1DogCa5wiVZJWFnFDezuw5XssoWWabijnE 3b300a84a7a01a23f0ad736e3d045f3248dfae5ca721df0447c7ac62d1ac0d6c
Tester 1: 10% * 10M DVC => 1,000,000.00 DVC paid to @cpsilent's address 14BL4enKz7LVbgVPQPQ3PUvETm58SA3Q8g 6fd7228089c6a2a6e445ba3155802c1406be43a755b34171eca49d504f66d80e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants