Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to java 11 and nio file management #72

Conversation

adamarmistead
Copy link
Contributor

Upgrade to junit 5 tests
Bumped version of all dependencies
Normalized formatting as recommended by SonarLint
Fixed Typos, and re-worded a lot of text to normalize verbiage Fixed BOOLEAN_TRUE_RETURN.html having the wrong ID Cleaned up formatting inconsistencies
Built/Tested/Verified against SonarQube 8.9.10 (build 61524) Ran SonarLint and resolved all issues not marked TODO

aarmistead-chwy and others added 3 commits April 13, 2023 21:04
Upgrade to junit 5 tests
Bumped version of all dependencies
Normalized formatting as recommended by SonarLint
Fixed Typos, and re-worded a lot of text to normalize verbiage
Fixed BOOLEAN_TRUE_RETURN.html having the wrong ID
Cleaned up formatting inconsistencies
Built/Tested/Verified against SonarQube 8.9.10 (build 61524)
Ran SonarLint and resolved all issues not marked TODO
@gmuecke gmuecke merged commit a34da2b into devcon5io:development Apr 8, 2024
@gmuecke
Copy link
Member

gmuecke commented Apr 8, 2024

Hi @adamarmistead
thank you for your contribution, and I appreciate the effort you put into it!
There were two minor issues left - one test fails and the pitest plugin requires a java5 plugin dependency, which I'll fix right away.
Cheers,
Gerald

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants