Use suggestions from @fred-asimov #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 29, 2022 14:44
Signed-off-by: Jacob Hummer <jcbhmr@outlook.com>
|
Any chance we can push this change through as a patch release, since 1.2.0 is already broken? Haha, I just realized you literally just opened this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #140, but I made an oopsie and renamed the branch, which closed the #140 PR. My bad!
This PR...
pulumi gen-completion bash | sudo tee /etc/bash_completion.d/pulumi > /dev/nullAnd hey look! I remembered to bump the version (after being prodded by @fred-asimov to do so, but still 馃檪)