Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes devcontainer-feature.json with comment #214

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

hellodword
Copy link
Contributor

@hellodword hellodword commented Feb 15, 2024

  1. formated via yarn format
node ➜ /workspaces/devcontainer-action (main) $ yarn format-check
yarn run v1.22.19
$ prettier --check '**/*.ts'
Checking formatting...
[warn] src/contracts/collection.ts
[warn] src/generateDocs.ts
[warn] src/main.ts
[warn] Code style issues found in 3 files. Forgot to run Prettier?
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

node ➜ /workspaces/devcontainer-action (main) $ yarn format
yarn run v1.22.19
$ prettier --write '**/*.ts'
__tests__/main.test.ts 133ms
__tests__/validateSchema.test.ts 16ms
src/contracts/collection.ts 9ms
src/contracts/features.ts 6ms
src/contracts/templates.ts 4ms
src/generateDocs.ts 33ms
src/main.ts 34ms
src/utils.ts 25ms
Done in 0.46s.
  1. remove the dependencies which're not been used by any scripts in the package.json.
  2. fixes Validate fails with comments #210 and add some test cases.

@hellodword hellodword requested a review from a team as a code owner February 15, 2024 08:15
@hellodword
Copy link
Contributor Author

@microsoft-github-policy-service agree

@hellodword hellodword changed the title Format via yarn format Fixes devcontainer-feature.json with comment Feb 15, 2024
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the quick fix! 🎉

Tested the action locally, works great.

@samruddhikhandale samruddhikhandale merged commit 5e57a2c into devcontainers:main Feb 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate fails with comments
2 participants