Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local feature not working in Remote-Containers #116

Closed
chrmarti opened this issue Aug 9, 2022 · 3 comments
Closed

Local feature not working in Remote-Containers #116

chrmarti opened this issue Aug 9, 2022 · 3 comments
Assignees
Labels
bug Something isn't working verified
Milestone

Comments

@chrmarti
Copy link
Contributor

chrmarti commented Aug 9, 2022

Remote-Containers 0.244.0

Using:

{
	"context": ".",
	"dockerFile": "Dockerfile",
	"features": {
		"./local-features/foo": "latest"
	}
}

fails with:

ENOENT: no such file or directory, lstat '/Users/chrmarti/.vscode-insiders/extensions/ms-vscode-remote.remote-containers-0.244.0/local-features/foo'
@chrmarti chrmarti added the bug Something isn't working label Aug 9, 2022
@chrmarti chrmarti added this to the August 2022 milestone Aug 9, 2022
@chrmarti chrmarti self-assigned this Aug 9, 2022
chrmarti added a commit that referenced this issue Aug 9, 2022
joshspicer pushed a commit that referenced this issue Aug 9, 2022
@rzhao271
Copy link
Contributor

On Windows, I get the error "Expected feature identifier to contain only alphanumeric and/or the '-' characters."
I'm also unable to build the container with that configuration.

@rzhao271 rzhao271 added the verification-steps-needed Steps to verify are needed for verification label Sep 1, 2022
@chrmarti
Copy link
Contributor Author

chrmarti commented Sep 1, 2022

Thanks @rzhao271, the following verifies the fix:

File layout:
image

devcontainer.json:

{
	"image": "ubuntu:latest",
	"features": {
		"./foo": "latest"
	}
}

devcontainer-feature.json:

{
    "id": "foo"
}

install.sh:

#!/bin/sh

echo HERE!
echo THERE! >/there.txt

In the devcontainer check that the file /there.txt exists.

(If you want to reproduce the problem in 0.244.0 first, you need to change the feature's path in the devcontainer.json to "./.devcontainer/foo". This changed later to be relative to the devcontainer.json.)

@chrmarti chrmarti removed the verification-steps-needed Steps to verify are needed for verification label Sep 1, 2022
@rzhao271
Copy link
Contributor

rzhao271 commented Sep 1, 2022

Verified in macOS on 0.252.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified
Projects
None yet
Development

No branches or pull requests

2 participants