Features Test Cmd: "Duplicate" test mode to test Feature Idempotence #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrmarti
requested changes
Jun 15, 2023
joshspicer
force-pushed
the
joshspicer/idempotencytest
branch
from
4bd2489
to
f5e9af8
Compare
joshspicer
force-pushed
the
joshspicer/idempotencytest
branch
from
8c89409
to
fc933f6
Compare
chrmarti
previously approved these changes
Jun 16, 2023
marketoptiontend
approved these changes
Jun 19, 2023
chrmarti
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/github/codespaces/issues/14081
This change adds a new mode that will be automatically executed if a
duplicate.shtest script is added to a Feature's test directory. This change will generate a dev container where a given Feature is installed twice in a row. This is to allow Feature authors to make assertions about what should happen if the exact Feature (with different options) is executed more than once.The first Feature installed will have random options based on the information in the
devcontainer-feature.json. The second Feature will be installed with the default options. The test scriptduplicate.shwill have both the random options and the default options available as environment variables to help write an accurate test.The intention here is is that authors can write tests asserting (1) every Feature that opts-in to this test by adding a
duplicate.shwill always succeed when it is installed >1 times and (2) there is predictable behavior (what Feature is on the path?) no matter what combination of options is provided