Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load NODE_EXTRA_CA_CERTS in Electron #559

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

chrmarti
Copy link
Contributor

@chrmarti chrmarti marked this pull request as ready for review June 21, 2023 09:48
@chrmarti chrmarti requested a review from a team as a code owner June 21, 2023 09:48
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@chrmarti chrmarti merged commit 265856f into main Jun 22, 2023
37 checks passed
@chrmarti chrmarti deleted the chrmarti/whispering-firefly branch June 22, 2023 06:35
deivid-rodriguez pushed a commit to joshspicer/dependabot-core that referenced this pull request Dec 21, 2023
…user back to dependabot

Needed because tools like dependabot/cli will proxy/MITM the traffic
to the registry with a cert that (without this change) is not known
to the dev container process

microsoft/vscode-remote-release#6092
https://github.com/devcontainers/cli/blob/2d24543380dfc4d54e76b582536b52226af133c8/src/spec-utils/httpRequest.ts#L130-L162
devcontainers/cli#559
deivid-rodriguez pushed a commit to joshspicer/dependabot-core that referenced this pull request Dec 21, 2023
…user back to dependabot

Needed because tools like dependabot/cli will proxy/MITM the traffic
to the registry with a cert that (without this change) is not known
to the dev container process

microsoft/vscode-remote-release#6092
https://github.com/devcontainers/cli/blob/2d24543380dfc4d54e76b582536b52226af133c8/src/spec-utils/httpRequest.ts#L130-L162
devcontainers/cli#559
deivid-rodriguez pushed a commit to joshspicer/dependabot-core that referenced this pull request Dec 22, 2023
…user back to dependabot

Needed because tools like dependabot/cli will proxy/MITM the traffic
to the registry with a cert that (without this change) is not known
to the dev container process

microsoft/vscode-remote-release#6092
https://github.com/devcontainers/cli/blob/2d24543380dfc4d54e76b582536b52226af133c8/src/spec-utils/httpRequest.ts#L130-L162
devcontainers/cli#559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants